Repository navigation
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Nov 8, 2026
Contributor
Author
|
All content has been split out so closing this one |
limadog9
pushed a commit
to limadog9/datafusion
that referenced
this pull request
Nov 11, 2026
## Which issue does this PR close? - split out of apache#27234. ## Rationale for this change While reviewing apache#27191 I was researching how `EquivalenceProperties` tracks orderings, equal expressions, constants and groupings, and wanted to write down what I learned so others do not have to repeat it. The concepts were documented in pieces across several structs, with no single place that explained them together. ## What changes are included in this PR? Rustdoc only. The `EquivalenceProperties` doc in `datafusion/physical-expr/src/equivalence/properties/mod.rs` becomes the hub that the other struct docs link to. It keeps the existing examples and adds: ## What is the testing strategy for this PR? CI ## Are there any user-facing changes? No. --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Jay Zhan <jayzhan211@gmail.com>
STUNSLAP
pushed a commit
to STUNSLAP/IIIllllIIl
that referenced
this pull request
Nov 11, 2026
…he#27237) ## Which issue does this PR close? - N/A, documentation only. ## Rationale for this change While reviewing apache#27191 I was researching how `EquivalenceProperties` tracks orderings and groupings, and wanted to write down what I learned so others do not have to repeat it. The `GroupingEquivalenceClass` docs described the property in prose but had no example, and did not say how it relates to `OrderingEquivalenceClass`, which it parallels. ## What changes are included in this PR? Rustdoc only, in `datafusion/physical-expr/src/equivalence/grouping.rs`: Split out of a larger documentation PR (apache#27234) for easier review. ## What is the testing strategy for this PR? CI ## Are there any user-facing changes? No. --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am doing a revamp of the docs for equivalence properties, etc
It seems SortKeyWalk was introduced in #26853
I'll break this into smaller PRs for review