Repository navigation
fix: handle SSL stores without an explicit type - #4359
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
ramanathan1504
left a comment
There was a problem hiding this comment.
The default in getPassword covers both call sites, and the new test fails with the NPE from #4346 without it.
Two small points inline, on SslConfigurationFactory and its test.
Assisted-by: Codex (GPT-5) Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
|
Updated in
|
|
@efegokdemir |
Summary
When only a key store or trust store location is configured, the SSL configuration factory passes a null store type to password handling and throws a
NullPointerException. Use Log4j's existing default key store type for password selection while retaining the existing configuration defaulting behavior.Changes
SslConfigurationDefaults.KEYSTORE_TYPE.Fixes #4346
Testing
git diff --check— passedxmllint --noout src/changelog/.2.x.x/4346_default_keystore_type.xml— passed./mvnw -pl log4j-core-test -Dtest=SslConfigurationFactoryTest test— blocked locally because the available runtime is Java 8 while the build requires newer JDK options (--add-exports).