Repository navigation
sqs: add the admin purge/peek audit line and counters (§3.6) #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a syntactically invalid but nonblank name such as
orders.bad, the route parser accepts the segment and this call receives the storage-layer nonexistent-queue error, so the new purge audit/counter recordsnot_found;AdminPeekQueuesimilarly recordsnot_foundwhen its metadata lookup returnsexists=false. Such names can never identify an SQS queue and §3.6 assigns malformed names tovalidation, so operator URL-construction errors are currently mixed with requests for valid queues that were deleted or do not exist. Run the existing queue-name validator before dispatching either operation and recordvalidationfor failures.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in signed commit c3a3aaf, with failing purge and peek regressions first. Both entrypoints now use the existing queue-name validator before storage dispatch and return/record validation for malformed names; padded whitespace is rejected rather than accepted through the trimming validator. Tests pin both sentinel errors, both observer outcomes, and the purge audit. Audited all callers through sqsQueuesBridge and translateAdminQueuesError to the existing structured HTTP 400 response. Targeted race suites and CI-equivalent v2.14.0 lint pass.