Repository navigation
Conversation
|
Apex Sentinel could not review commit Apex Sentinel did not review this pull request, as |
There was a problem hiding this comment.
All reported issues were addressed across 117 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Live checks on Limrun iOS 26.4 for the commands earlier runs never exercised. The build is #4182
The |
The review follow-up narrowed --launch-console to local simulators, but no provider guard refuses it on Limrun: app-launch.ts refuses only non-simulator devices, and a live Limrun iOS 26.4 open with --launch-console succeeded and captured the launch console. This restores the original wording. Co-Authored-By: Claude <noreply@anthropic.com>
a1071a4 to
2418c79
Compare
Size Report
Startup median (7 runs, lower is better):
|
|
Live on Limrun iOS 26.4 after the rebase onto main. The build is #4182
|
|
At 2418c79, the switch of Limrun iOS to the shared XCTest runner looks right in code. One live run is needed before merge. This PR replaces every Limrun iOS producer: text entry, alerts, and runner launch, cancel and release (see ios.ts:180). The live runs on record cover appstate, install, open, press, screenshot, snapshots, settings, uninstall,
Not blocking, take or leave:
The only failing check refused to run because the diff is over its size limit, so it says nothing about the code; the other 21 checks pass. There are no conflicts. The earlier inline threads on uninstall, push, the plist runtime dependency, setSetting scope, open/close and |
|
Superseded by #4224, which landed the same switch of Limrun iOS to the shared XCTest runner. #4243 ports the genuine extras from this PR (stale alert/settings/launch-console wording, the apple-runner entry comment) plus the still-applicable cleanups from the review: removing the unused |
Summary
Follow up on #4224 in 19 files: remove the unused Limrun iOS app-alias adapter and redundant cancellation wrapper, and correct settings help and stale AX descriptions. Main already contains the app-state simplification and removes
limrun-ios-tree. The runner switch in #4224 bundles plist; its earlier size report showed a 45.4 kB download increase.Validation
63f6cbc5c835b44d5043228f813c55dc63e6bf83, base22bd671066f256a195f934c317ce17ec6ed4ddf3.pnpm install --frozen-lockfile && pnpm buildandpnpm exec tsc -bpassed; the Limrun Vitest selection passed 33 files and 243 tests at this head.pnpm check:affected --run --head 63f6cbc5c835b44d5043228f813c55dc63e6bf83: passed,exactCommit=true,checkoutChanged=false; local receipt.tmp/validation/run-2rx9YR/receipt.json. GitHub owns the skipped device and integration lanes.