Repository navigation
docs(capture): correct stale Limrun and Revyl capture comments - #4254
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
2 issues found across 18 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/contracts/src/interactor-types.ts">
<violation number="1" location="packages/contracts/src/interactor-types.ts:176">
P3: This comment no longer identifies the current producer of `textEntryReadiness` and introduces the otherwise undefined “tree-based entry” category. Say that the WebDriver interactor populates it, or document the actual readiness mechanism.</violation>
</file>
<file name="packages/provider-revyl/src/snapshot.ts">
<violation number="1" location="packages/provider-revyl/src/snapshot.ts:50">
P3: Revyl still parses the iOS hierarchy with its local `parseIosTree`; only flattening and interpretation use shared helpers. Replace “shared reader” with the actual local-parser/shared-helper split.</violation>
</file>
Apex SentinelVerdict: Since the last review: 0 new · 0 still open · 0 no longer raised No findings. Not in the reviewers' prompt (2 files)
Reviewed with this repository's own Sentinel configuration ( Reply under an inline comment with Earlier reviewsReview of
|
|
This PR is ready at 2e7e090, and I found no problems in the code. All 19 checks pass, and there are no conflicts. The one open question is which PR to keep: #4243 contains every production change in this PR, so only one of the two should merge. Not blocking, take or leave: #4243 also has the alert help fix, the facade export removal and an extra integration test that this PR lacks, so if this PR survives, those are worth taking; The two open P3 threads still apply: textEntryReadiness wording and Revyl shared reader. Before merge, please close one of this PR and #4243. If #4243 is kept, its change to the |
The viewport test still listed a Limrun tree acquisition that #4243 removed, and the Revyl iOS comment said the tree goes through the capture kit's reader while Revyl parses its own hierarchy and only flattens and interprets through the capture kit.
2e7e090 to
c40443e
Compare
#4243 landed every production change this PR first carried (the unused iOS app-alias seam, the stale AX-backend wording, the alert help fix and the façade export). After rebasing onto main, this PR keeps only two comment fixes that #4243 did not cover:
ios-snapshot-runtime-viewport.test.ts: drop the Limrun tree acquisition from the list. That acquisition no longer exists.provider-revyl/src/snapshot.ts: state that Revyl parses its own hierarchy JSON (parseIosTree) and only flattens and interprets the tree through the capture kit. This is the open Cubic thread.No behavior changes.