Skip to content

docs(capture): correct stale Limrun and Revyl capture comments - #4254

Merged
thymikee merged 1 commit into
mainfrom
chore/limrun-runner-cleanup
Nov 6, 2026
Merged

thymikee merged 1 commit into
mainfrom
chore/limrun-runner-cleanup

Conversation

@thymikee

@thymikee thymikee commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

#4243 landed every production change this PR first carried (the unused iOS app-alias seam, the stale AX-backend wording, the alert help fix and the façade export). After rebasing onto main, this PR keeps only two comment fixes that #4243 did not cover:

  • ios-snapshot-runtime-viewport.test.ts: drop the Limrun tree acquisition from the list. That acquisition no longer exists.
  • provider-revyl/src/snapshot.ts: state that Revyl parses its own hierarchy JSON (parseIosTree) and only flattens and interprets the tree through the capture kit. This is the open Cubic thread.

No behavior changes.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.14 MB 6.14 MB 0 B
Package (unpacked) 6.14 MB 6.14 MB 0 B
Package (download) 1.86 MB 1.86 MB -3 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 24.2 ms 21.8 ms -2.3 ms
CLI --help 49.3 ms 45.2 ms -4.1 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 18 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/contracts/src/interactor-types.ts">

<violation number="1" location="packages/contracts/src/interactor-types.ts:176">
P3: This comment no longer identifies the current producer of `textEntryReadiness` and introduces the otherwise undefined “tree-based entry” category. Say that the WebDriver interactor populates it, or document the actual readiness mechanism.</violation>
</file>

<file name="packages/provider-revyl/src/snapshot.ts">

<violation number="1" location="packages/provider-revyl/src/snapshot.ts:50">
P3: Revyl still parses the iOS hierarchy with its local `parseIosTree`; only flattening and interpretation use shared helpers. Replace “shared reader” with the actual local-parser/shared-helper split.</violation>
</file>

Comment thread packages/provider-revyl/src/snapshot.ts Resolved
@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Apex Sentinel

Verdict: approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No findings.

Not in the reviewers' prompt (2 files)
  • packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts: no reviewer was selected for this change
  • packages/provider-revyl/src/snapshot.ts: no reviewer was selected for this change

Reviewed with this repository's own Sentinel configuration (38038786abfc).

Reply under an inline comment with @apex-sentinel-staging note ... or @apex-sentinel-staging pivot ... to re-check that finding.
Comment @apex-sentinel-staging review on this conversation to run a full review.

Earlier reviews

Review of 2e7e0901 · 06.11.2026 05:08 UTC

Apex Sentinel

Verdict: approve

No findings.

1 finding below minor not shown (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (b42c7c265f07).

@thymikee

thymikee commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

This PR is ready at 2e7e090, and I found no problems in the code. All 19 checks pass, and there are no conflicts. The one open question is which PR to keep: #4243 contains every production change in this PR, so only one of the two should merge.

Not blocking, take or leave: #4243 also has the alert help fix, the facade export removal and an extra integration test that this PR lacks, so if this PR survives, those are worth taking; resolveIosAppAlias is still exported from app-resolution-facade.ts with no consumer left, so you could drop it from the facade and make the core function module-private; the alert help in alert.ts still says Limrun iOS stays English, so could you check whether the Limrun runner recognizes localized labels and align the help or say it is unchanged; and the comment at interactor-types.ts could say that the WebDriver interactor populates textEntryReadiness.

The two open P3 threads still apply: textEntryReadiness wording and Revyl shared reader.

Before merge, please close one of this PR and #4243. If #4243 is kept, its change to the --launch-console refusal text should be reverted. The refusing branch in application-lifecycle-interaction.ts throws for every provider-owned device, so Limrun launches are still refused, and this PR correctly leaves that message alone.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 6, 2026
The viewport test still listed a Limrun tree acquisition that #4243 removed,
and the Revyl iOS comment said the tree goes through the capture kit's reader
while Revyl parses its own hierarchy and only flattens and interprets through
the capture kit.
@thymikee
thymikee force-pushed the chore/limrun-runner-cleanup branch from 2e7e090 to c40443e Compare November 6, 2026 07:18
@thymikee thymikee changed the title refactor(limrun): remove obsolete iOS adapter paths after the runner switch docs(capture): correct stale Limrun and Revyl capture comments Nov 6, 2026
@thymikee
thymikee merged commit 3a780de into main Nov 6, 2026
17 checks passed
@thymikee
thymikee deleted the chore/limrun-runner-cleanup branch November 6, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant