Skip to content

docs(capture): correct stale Limrun and Revyl capture comments #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Nov 6, 2026
Merged

docs(capture): correct stale Limrun and Revyl capture comments #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/capture-kit/src/snapshot/__tests__/ios-snapshot-runtime-viewport.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type { IosViewportEvidence } from '@agent-device/contracts/ios-snapshot';
import { AppError } from '@agent-device/kernel/errors';
import type { RawSnapshotNode } from '@agent-device/kernel/snapshot';

// #3182: the provider acquisitions — the simulator AX bridge, an Appium page source, a Limrun tree —
// #3182: the provider acquisitions — the simulator AX bridge or an Appium page source —
// already resolve the box their nodes are measured in, and this presenter is the one seam that turns
// an acquisition into a snapshot result. Publishing nothing here left the default local-iOS producer
// without a viewport while it held the evidence, which is the issue's first `Done when` line.
Expand Down
4 changes: 2 additions & 2 deletions packages/provider-revyl/src/snapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export async function captureRevylSnapshot(
}

/**
* iOS: the AX node tree goes through the capture kit's iOS AX tree reader and interpreter, and comes
* back as an acquisition for the host to present. The viewport is the tree's own application root,
* iOS: Revyl's hierarchy JSON is parsed here into an AX node tree; the capture kit then flattens and
* interprets it, and it comes back as an acquisition for the host to present. The viewport is the tree's own application root,
* because that is the box its frames were measured in; without a usable root it is `health`'s screen,
* which Revyl reports in the same points on iOS.
*/
Expand Down
Loading