Repository navigation
Conversation
Ikreb1
force-pushed
the
EF-21552-firing-effect-cull-fix
branch
from
November 19, 2026 10:16
72a0d54 to
32f2fcc
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Detached firing effects can be rendered twice when captured in impostor sprites, while nested turret effects still disappear because three child wrappers do not forward detached renderables.
2 open issues
What changed in this PR
This PR adds a detached-renderable path to Trinity’s space-object rendering so turret firing effects can remain visible when their owner is off-screen or rendered as an impostor.
Changes:
- Add a default no-op
GetDetachedRenderables()hook for space-object children. - Override the hook for turrets to submit firing effects independently.
- Collect detached effect renderables when normal child rendering is skipped.
| File | Description |
|---|---|
trinity/Eve/SpaceObject/EveSpaceObject2.cpp |
Collects detached effects for culled or impostored owners. |
trinity/Eve/SpaceObject/Children/EveSpaceObjectChild.h |
Declares and documents the detached-renderable hook. |
trinity/Eve/SpaceObject/Children/EveSpaceObjectChild.cpp |
Provides the default no-op implementation. |
trinity/Eve/SpaceObject/Children/EveChildTurret.h |
Declares the turret override. |
trinity/Eve/SpaceObject/Children/EveChildTurret.cpp |
Submits turret firing effects through the new hook. |
Review effort: Balanced
Ikreb1
force-pushed
the
EF-21552-firing-effect-cull-fix
branch
from
November 19, 2026 15:41
6de2718 to
4038975
Compare
Comment on lines
+37
to
+39
| void GetDetachedRenderables( std::vector<ITr2Renderable*>& renderables ) override; | ||
| void RegisterWithQuadRenderer( Tr2QuadRenderer& quadRenderer ) override; | ||
| void AddDetachedQuadsToQuadRenderer( const TriFrustum& frustum, Tr2QuadRenderer& quadRenderer ) const override; |
…ner is culled or impostored
Ikreb1
force-pushed
the
EF-21552-firing-effect-cull-fix
branch
from
November 20, 2026 14:04
4cfb2b6 to
91769d3
Compare
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Only 2 out of 6 clang-format concerns fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/trinity/Eve/SpaceObject/Children/EveChildTurret.h b/trinity/Eve/SpaceObject/Children/EveChildTurret.h
--- a/trinity/Eve/SpaceObject/Children/EveChildTurret.h
+++ b/trinity/Eve/SpaceObject/Children/EveChildTurret.h
@@ -28 +28 @@ public:
- bool OnModified( Be::Var * value ) override;
+ bool OnModified( Be::Var* value ) override;
@@ -32,2 +32,2 @@ public:
- void GetDebugOptions( Tr2DebugRendererOptions & options ) override;
- void RenderDebugInfo( ITr2DebugRenderer2 & renderer ) override;
+ void GetDebugOptions( Tr2DebugRendererOptions& options ) override;
+ void RenderDebugInfo( ITr2DebugRenderer2& renderer ) override;
@@ -39 +39 @@ public:
- void RegisterWithQuadRenderer( Tr2QuadRenderer & quadRenderer ) override;
+ void RegisterWithQuadRenderer( Tr2QuadRenderer& quadRenderer ) override;
@@ -46 +46 @@ public:
- void BuildCachedGeometryData( TriGeometryRes & geometryRes );
+ void BuildCachedGeometryData( TriGeometryRes& geometryRes );
@@ -95 +95 @@ protected:
- void SetFiringEffect( EveTurretFiringFX * firingEffect );
+ void SetFiringEffect( EveTurretFiringFX* firingEffect );
@@ -98 +98 @@ protected:
- void SetTargetObject( IRoot * target );
+ void SetTargetObject( IRoot* target );
✨ Powered by cpp-linter • 💬 Feedback
| void UpdateAsyncronous( const EveUpdateContext& updateContext, const EveChildUpdateParams& params ) override; | ||
| void UpdateVisibility( const EveUpdateContext& updateContext, const Matrix& parentTransform, Tr2Lod parentLod ) override; | ||
| void GetRenderables( std::vector<ITr2Renderable*> & renderables ) override; | ||
| void RegisterWithQuadRenderer( Tr2QuadRenderer & quadRenderer ) override; |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| void RegisterWithQuadRenderer( Tr2QuadRenderer & quadRenderer ) override; | |
| void RegisterWithQuadRenderer( Tr2QuadRenderer& quadRenderer ) override; |
| void AddUnboundedQuads( const TriFrustum& frustum, Tr2QuadRenderer& quadRenderer ) const override; | ||
|
|
||
| void UpdateCachedGeometryData(); | ||
| void BuildCachedGeometryData( TriGeometryRes & geometryRes ); |
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| void BuildCachedGeometryData( TriGeometryRes & geometryRes ); | |
| void BuildCachedGeometryData( TriGeometryRes& geometryRes ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
enable detachedRenderables for effect children so off screen EveChildTurrets still render the firing effect
Linked issue (optional)
(https://fenriscreations.atlassian.net/browse/EF-21552)
Testing
tested in client
AI assistance
AI diagnosed the issue