Repository navigation
enable detachedRenderables for effect children so off screen EveChildTurrets still render the firing effect #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ikreb1
wants to merge
1
commit into
main
Choose a base branch
from
EF-21552-firing-effect-cull-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Copyright © 2026 Fenris Creations ehf. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "Eve/EveComponentRegistry.h" | ||
|
|
||
| class TriFrustum; | ||
| class Tr2QuadRenderer; | ||
| struct ITr2Renderable; | ||
|
|
||
| // Renderables that reach outside their owner's bounds (f.ex. a turret firing effect hitting its target). | ||
| // The scene collects them directly, so they draw whether the owner is visible, culled or impostored. | ||
| // Each one does its own frustum test. | ||
| struct IEveUnboundedRenderable | ||
| { | ||
| virtual void GetUnboundedRenderables( std::vector<ITr2Renderable*>& renderables ) = 0; | ||
| virtual void AddUnboundedQuads( const TriFrustum& frustum, Tr2QuadRenderer& quadRenderer ) const = 0; | ||
| }; | ||
|
|
||
| REGISTER_COMPONENT_TYPE( "UnboundedRenderable", IEveUnboundedRenderable ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||
| // Copyright © 2026 Fenris Creations ehf. | ||||||
|
|
||||||
| #pragma once | ||||||
|
|
@@ -5,6 +5,7 @@ | |||||
| #define EveChildTurret_H | ||||||
|
|
||||||
| #include "EveChildMesh.h" | ||||||
| #include "Eve/IEveUnboundedRenderable.h" | ||||||
| #include "Eve/Turret/EveTurretAiming.h" | ||||||
| #include "Eve/Turret/EveTurretTarget.h" | ||||||
| #include "include/ITr2PoseModifier.h" | ||||||
|
|
@@ -14,7 +15,8 @@ | |||||
|
|
||||||
| BLUE_CLASS( EveChildTurret ) : | ||||||
| public EveChildMesh, | ||||||
| public ITr2PoseModifier | ||||||
| public ITr2PoseModifier, | ||||||
| public IEveUnboundedRenderable | ||||||
| { | ||||||
| public: | ||||||
| EXPOSE_TO_BLUE(); | ||||||
|
|
@@ -34,9 +36,11 @@ | |||||
| void UpdateSyncronous( const EveUpdateContext& updateContext, const EveChildUpdateParams& params ) override; | ||||||
| void UpdateAsyncronous( const EveUpdateContext& updateContext, const EveChildUpdateParams& params ) override; | ||||||
| void UpdateVisibility( const EveUpdateContext& updateContext, const Matrix& parentTransform, Tr2Lod parentLod ) override; | ||||||
| void GetRenderables( std::vector<ITr2Renderable*> & renderables ) override; | ||||||
| void RegisterWithQuadRenderer( Tr2QuadRenderer & quadRenderer ) override; | ||||||
| void AddQuadsToQuadRenderer( const TriFrustum& frustum, Tr2QuadRenderer& quadRenderer ) const override; | ||||||
|
|
||||||
| // IEveUnboundedRenderable: the firing effect reaches the target outside the owner's bounds | ||||||
| void GetUnboundedRenderables( std::vector<ITr2Renderable*>& renderables ) override; | ||||||
| void AddUnboundedQuads( const TriFrustum& frustum, Tr2QuadRenderer& quadRenderer ) const override; | ||||||
|
|
||||||
| void UpdateCachedGeometryData(); | ||||||
| void BuildCachedGeometryData( TriGeometryRes & geometryRes ); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. clang-format suggestion
Suggested change
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format suggestion