Repository navigation
Conversation
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
VIDEO-21243
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: VIDEO-21243
Follow-up to #1097. Adds shareable demos of the new format options. Not for merge: this PR exists for its deploy preview.
As-is delivery page
New
as-is-delivery.html(linked from the examples index) showssourceTypes: ['']:sourceTypes: ['']delivers.../upload/sea_turtle, with no transformation.sourceTypes: [''], transformation: { width: 640, crop: 'limit' }deliversc_limit,w_640/sea_turtle, still withoutf_auto.Each example shows the delivered URL, content type and file size, measured live in the viewer's browser. The original example also shows the size of the default
f_auto:videodelivery for comparison (in Chrome: 27.9 MB original vs 1.6 MBwebm/vp9). The page also covers when to use it, the trade-offs, asourceTypesURL reference and example code.Codecs and formats page
What changed
Three new players on
codec-formats.htmlandes-modules/codec-formats.html:transformation: { fetch_format: 'mp4' }f_mp4/product-gallery-tutorial_hlk0natransformation: { format: 'mp4' }(alias)f_mp4/product-gallery-tutorial_hlk0nasourceTypes: [''](as-is, nof_auto)product-gallery-tutorial_hlk0naThe new players don't autoplay. With six autoplaying players on one page, Chrome only buffers some of them, and the rest stay stuck on load.
Known issue
With
transformation: { fetch_format: 'mp4' }, the seek-thumbnails sprite URL becomesf_mp4/fl_sprite/...vtt(400). Playback isn't affected. Fixed in #1100.Testing
Checked on the local docs server: