Repository navigation
Conversation
A source fetch_format (or its format alias) leaked into derived image URLs: the seek-thumbnails sprite became f_mp4/fl_sprite/...vtt (400), and a poster built from posterOptions was delivered as a video. VIDEO-21243
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: VIDEO-21243
Follow-up to #1097, found while testing #1099.
Why
The source transformation is inherited by derived image URLs (seek-thumbnails sprite, and the poster when
posterOptionsis set).omitVideoOnlyTransformationsstripsstreaming_profileandvideo_codecfor these URLs, but notfetch_format. Withtransformation: { fetch_format: 'mp4' }:f_mp4/fl_sprite/....vttgives 400 (fl_sprite is only supported with 'vtt' or 'jpg' format).posterOptions:f_mp4/....jpgis delivered asvideo/mp4.This predates #1097, but #1097 and #1099 now recommend
fetch_format/format, so it is easier to hit.What changed
fetch_formatand itsformatalias toVIDEO_ONLY_TRANSFORMATION_KEYSinsrc/plugins/cloudinary/common.js.omitVideoOnlyTransformations(object, array, and chained forms).Testing
npm run test:unitpasses (146 tests).fetch_format: 'mp4'andformat: 'mp4': the sprite URL isfl_sprite/....vtt(200), and theposterOptionsposter isc_scale,w_600/....jpg.