Repository navigation
feat(chat): open date separators after a one-hour pause - #1867
Merged
Merged
Conversation
The transcript's SeparatorConfig.Continuous started a new separator only after a three-hour pause, so a morning and an afternoon exchange on the same day read as one run. Drop the gap to one hour. iOS gets the same change so both apps split a transcript in the same places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcript date separators now open after a one-hour pause instead of three hours, so a morning and an afternoon exchange on the same day no longer read as one run. iOS makes the same change in code-payments/code-ios-app#1145.
SeparatorConfig.Continuousdefaults to1.hours. This is the configChatViewModeluses for the transcript.TimeGapstays at three hours. Its only use is the animated preview inConversationPreview.kt.SeparatorConfigTest: a 90-minute pause separates; 30 minutes and exactly one hour do not.