Repository navigation
feat(chat): open date separators after a one-hour pause - #1145
Merged
Merged
Conversation
The transcript's separator gap was three hours, so a morning and an afternoon exchange on the same day read as one run. Drop it to one hour, matching Android's SeparatorConfig.Continuous. ChatPreviewMapping, which builds the notification preview, used 15 minutes while its doc comment said it matched the in-app chat. It now uses the same one hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transcript date separators now open after a one-hour pause instead of three hours, so a morning and an afternoon exchange on the same day no longer read as one run. Android makes the same change in code-payments/code-android-app#1867.
ChatItem.from's defaultgapis60 * 60.ChatPreviewMapping.separatorGapwas 15 minutes, though its doc comment says it matches the in-app chat. It is now one hour, so notification previews split where the transcript does.hourGapOpensSeparatorinChatMessageMappingTests(30 minutes keeps one separator, 90 minutes adds a second). InChatPreviewMappingTests, the gap case moves from a ~16-minute pause to 90 minutes, andshortPauseKeepsOneSeparatorcovers 30 minutes.