Repository navigation
acceptance: always distinguish UUIDs in test output - #7021
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
github-actions
Bot
added
DABs
denik
previously approved these changes
Oct 12, 2026
| matches := repl.Old.FindAllString(s, -1) | ||
| if len(matches) <= 1 { | ||
| // Assign a stable [N] suffix per distinct matched value, in order of first | ||
| // appearance. Number only when there is more than one distinct value: a lone |
Contributor
There was a problem hiding this comment.
I'd send this change as separate PR, to separate all those diffs unrelate to UUIDs.
Member
Author
denik
reviewed
Oct 12, 2026
| "name": "schema-[UNIQUE_NAME]", | ||
| "owner": "[USERNAME]", | ||
| "schema_id": "[UUID]", | ||
| "updated_at": [UNIX_TIME_MILLIS][0], |
Member
Author
There was a problem hiding this comment.
created_at and updated_at contain the same timestamp, so there is only one distinct value. The generic change adds suffixes only when there are multiple distinct values; repeated occurrences of a single value stay unsuffixed. That behavior and these timestamp golden changes now live in #7420. This PR only adds UUID numbering to metastore_id and schema_id in this file.
Collaborator
❌ Integration test reportCommit: 4190d12
11 interesting tests: 11 FAIL
Top 1 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 9, 2026 22:54
767640b to
8fabaa1
Compare
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 83 not selected) 25 tests: regression=0 unreleased=0 coverage=25 failing=0
|
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 9, 2026 23:30
8fabaa1 to
4190d12
Compare
janniklasrose
changed the base branch from
janniklasrose/acc/uuid-unique-knob
to
janniklasrose/acc/uuid-compatible-tests
November 9, 2026 23:31
janniklasrose
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the temporary
UniqueUUIDoption and always distinguish UUIDs. Remove its obsolete opt-out tests and regenerate acceptance goldens: the 115 regenerated golden files contain only UUID numeric-suffix changes.Why
Expected output should distinguish different UUIDs consistently. #7423 handles the immutable and template tests, so this PR needs no test-script or comparison-helper fixes.
Tests
./task test-update,./task fmt,./task checks,./task lint, and./task testpassed. The acceptance runner retried two transientjob-referencesGit-metadata failures successfully; all final results passed, including both immutable variants and the template comparisons.This PR was written by Isaac and revised with Codex.