Skip to content

acceptance: prepare plan and template comparisons for UUID numbering - #7423

Draft
janniklasrose wants to merge 1 commit into
janniklasrose/acc/uuid-unique-knobfrom
janniklasrose/acc/uuid-compatible-tests
Draft

janniklasrose wants to merge 1 commit into
janniklasrose/acc/uuid-unique-knobfrom
janniklasrose/acc/uuid-compatible-tests

Conversation

@janniklasrose

Copy link
Copy Markdown
Member

Changes

Capture the immutable no-artifacts test's initial plan in a separate golden, preserving its assertions. Teach the Python replacement helper to honor Distinct so template comparisons can match numbered goldens.

Why

Saved-plan deployment reuses the planned snapshot UUID; direct deployment generates another. Separate plan output lets both variants share expectations. Template comparisons also need the same numbering behavior as the Go harness before #7021 removes the UUID opt-out.

Stacked on #7020. UUID numbering remains off by default in this PR.

Tests

Both immutable variants, template tests, and helper selftests passed with numbering off. Python doctests cover repeated values, multiple distinct values, and already-normalized output. Formatting, checks, lint, and the full test suite passed with numbering always enabled on the completed stack; #7021 records the transient retry.

This PR was written by Codex.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Commit: d9d1f41e8 | Workflow run

Regression test report

Selected 20 changed tests (limit=20, 7 not selected)

35 tests: regression=0 unreleased=0 coverage=35 failing=0
test branch main (b694c4c) latest (v1.25.0)
TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS= ✅ ✅ ✅
TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS=true ✅ ✅ ✅
TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS= ✅ ✅ ✅
TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS=true ✅ ✅ ✅
TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN= ✅ ✅ ✅
TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN=1 ✅ ✅ ✅
TestAccept/bundle/deploy/readplan/whl-upload/DMS= ✅ ✅ ✅
TestAccept/bundle/integration_whl/serverless_extras_dynamic_version/DMS= ✅ ✅ ✅
TestAccept/bundle/integration_whl/serverless_extras_dynamic_version/DMS=true ✅ ✅ ✅
TestAccept/bundle/migrate/command/default-python/DMS= ✅ ✅ ✅
TestAccept/bundle/migrate/command/grants/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/dashboards/detect-change/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/dashboards/detect-change/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/job_runs/retried_run_now/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/job_runs/retried_run_now/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/basic/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/basic/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/catalog-name/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/catalog-name/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/name-change/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/name-change/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/route-optimized/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/route-optimized/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/schema-name/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/schema-name/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/table-prefix/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/recreate/table-prefix/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/ai-gateway/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/ai-gateway/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/both_gateway_and_tags/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/both_gateway_and_tags/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/config/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/model_serving_endpoints/update/config/DMS=true ✅ ✅ ✅
TestAccept/selftest/uuid ✅ ✅ ✅
TestAccept/selftest/uuid_not_unique ✅ ✅ ✅

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: d9d1f41

Run: 42721334007

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 286 37 4:21
✅​ aws-windows-latest-4core-16gb 288 35 4:22
✅​ azure linux-2core-8gb 285 37 4:42
✅​ azure-windows-latest-4core-16gb 287 35 3:36
✅​ gcp linux-2core-8gb 286 37 4:20
✅​ gcp-windows-latest-4core-16gb 288 35 4:36
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:16 gcp-windows-latest-4core-16gb TestAccept
3:13 aws-windows-latest-4core-16gb TestAccept
2:33 azure-windows-latest-4core-16gb TestAccept

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants