Skip to content

Open an issue when a scheduled bump workflow fails - #7312

Merged
pietern merged 8 commits into
mainfrom
bump-vuln-deps-failure-issue
Nov 3, 2026
Merged

pietern merged 8 commits into
mainfrom
bump-vuln-deps-failure-issue

Conversation

@pietern

@pietern pietern commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

The scheduled Bump vulnerable dependencies workflow failed every day from Oct 9 to Oct 15 (JFrog returned 403 for golang.org/x/net@v0.60.0, then a transient actions/setup-go download failure), and nobody noticed because a failed scheduled run is only visible in the Actions tab. The fix for the Oct 8 x/net advisories landed in #7083 on Oct 16 as a result. Bump Go toolchain has the same blind spot.

This adds a composite action, .github/actions/report-failure, and runs it as the last step of both workflows with if: failure(). It opens an issue that links the failed run and is assigned to the same people each workflow already requests as PR reviewers. The assignee list lives in each workflow next to its reviewers: list so the two are easy to keep in sync. If an open issue with the workflow's label (bump-vuln-deps-failure or bump-go-toolchain-failure) already exists, it comments on it instead, so a multi-day outage produces a single issue. The label is created on first use. Both jobs gain issues: write for this.

The issue body also mentions @databricks/eng-deco-cli, but a team mention posted by github-actions did not notify team members in testing, which is why the issue is assigned to individuals.

Tested by temporarily forcing the vulnerable-dependency workflow to fail on this branch and dispatching it. The first run, with an earlier inline version that only had the team mention, created #7311 but sent no notification (run). The second run, with the final action, created #7316 with all seven assignees and delivered an assignment notification (run). Both issues were closed as tests, and the simulated failure is reverted on the branch.

This pull request and its description were written by Isaac.

pietern and others added 3 commits November 3, 2026 14:09
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern requested a review from a team as a code owner November 3, 2026 13:12
@janniklasrose

Copy link
Copy Markdown
Member

same for bump go toolchain?

pietern and others added 2 commits November 3, 2026 14:18
Co-authored-by: Isaac <no-reply@databricks.com>
Move the Report failure step into a composite action and use it from both
scheduled bump workflows.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern pietern changed the title Open an issue when the vulnerable-dependency bumper fails Open an issue when a scheduled bump workflow fails Nov 3, 2026

@pietern pietern left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janniklasrose Good suggestion, done!

pietern and others added 3 commits November 3, 2026 14:30
A team mention posted by github-actions did not notify the team's members.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern enabled auto-merge November 3, 2026 13:33
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: c56b0a0

Run: 41645264666

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 7:34
✅​ aws-windows-latest-4core-16gb 273 13 5:12
🔄​ azure linux-2core-8gb 2 268 15 8:53
✅​ azure-windows-latest-4core-16gb 272 13 4:54
✅​ gcp linux-2core-8gb 271 15 7:50
✅​ gcp-windows-latest-4core-16gb 273 13 5:41
Test Name azure linux-2core-8gb
🔄​ TestFsCpFileToDirWithOverwriteFlag 🔄​f
🔄​ TestFsCpFileToDirWithOverwriteFlag/uc-volumes_to_local 🔄​f
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:17 azure linux-2core-8gb TestAccept
4:13 gcp linux-2core-8gb TestAccept
4:08 aws linux-2core-8gb TestAccept
3:13 azure-windows-latest-4core-16gb TestAccept
3:10 aws-windows-latest-4core-16gb TestAccept
2:56 gcp-windows-latest-4core-16gb TestAccept

@pietern
pietern added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit c0e1859 Nov 3, 2026
28 checks passed
@pietern
pietern deleted the bump-vuln-deps-failure-issue branch November 3, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants