[ci] Run PR checks on release branches (release-0.30) - #467
Open
Glitchy-Sheep wants to merge 1 commit into
Open
Conversation
Same one-line fix as #441 for release-0.32: PRs into this branch get no CI because the pull_request trigger only matches base main. Recent backports show the cost: #460 broke the v0.30.22 build and it was only caught when the tag was built (#461). The pr-build job would have caught it at PR time. Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PRs into
release-0.30get no CI. The only check they receive is DCO. Thepull_requesttrigger in.github/workflows/release.yamlmatches only basemain, sotest,lintandpr-buildnever start for PRs into this branch.The recent backports show the cost. #459, #460 and #461 all merged here without checks, and #460 broke the
v0.30.22build - it was only caught when the tag was built, and #461 exists solely to fix that. Thepr-buildjob would have caught it at PR time.Fix
Add
release-*to the trigger filter. Same one-line fix as #441 does forrelease-0.32.The jobs need no changes:
release,test,lintandpr-buildall exist in this branch and the Taskfile targets they call are present.Proof
This PR runs its own checks: for
pull_requestevents GitHub reads the workflow from the merge ref of the PR, so the new filter already applies here.The same change lands on
mainseparately, so future release branches are cut with the filter already correct.