Skip to content

GLSP-1823: Publish releases on push of their signed tag - #150

Merged
tortmayr merged 2 commits into
masterfrom
deploy-release-mode
Nov 10, 2026
Merged

tortmayr merged 2 commits into
masterfrom
deploy-release-mode

Conversation

@tortmayr

@tortmayr tortmayr commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

What it does

Publishes a release from GitHub Actions when its signed tag v<version> is pushed, replacing the dispatch from the umbrella release workflow. glsp releng release (eclipse-glsp/glsp-core#41) pushes this tag once the release PR is merged and CI passed on the release commit, and creates the GitHub release itself.

  • Add a Release workflow that runs on pushes of final release tags v<major>.<minor>.<patch>. Before publishing it checks that the tag is a final release (v<major>.<minor>.<patch>) matching the server pom version, that it is signed and verified by GitHub, and that ci-server.yml passed on the tagged commit
  • Upload the p2 repository to releases/<version> through a temporary dir that is renamed on success, and refuse to overwrite an existing release
  • Publish the client packages under latest from publish.yml on the same tag push, with the same tag and CI checks against client/package.json and ci.yml. Publishing stays in publish.yml because npm trusted publishing is bound to the workflow file, and the manual dispatch stays available as a fallback. next publishes skip release versions
  • Remove publish-release.yml, which dispatched the umbrella workflow
  • Skip the nightly deploy for non-snapshot versions in a version job that runs before the build, so merging a release PR no longer adds the release to the nightly composite

Part of: eclipse-glsp/glsp#1823

How to test

The release jobs run for the first time with the next real release. The build and upload steps mirror the nightly deploy job, which already runs green.

  • The tag checks run against real tags: an unsigned annotated tag (v2.8.0) and a lightweight tag are rejected, signed tags pass
  • The CI guard passes for a commit with green CI and fails for missing and red CI
  • After merge, the nightly deploy still runs for the snapshot version on master

Follow-ups

  • Release the javax variants (v<version>.javax) and release candidates
  • Add a tag ruleset that restricts who can push v* tags
  • Remove prepare-release.yml after the first release with the new flow
  • Move the p2 build and SSH setup steps shared by release.yml and deploy.yml into a local composite action

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Add a Release workflow that runs when the tag v<version> is pushed.
  Before publishing it checks that the tag is a final release
  (v<major>.<minor>.<patch>) matching the server pom version, that it
  is signed and verified by GitHub, and that the server CI passed on
  the tagged commit
- Upload the p2 repository to releases/<version> through a temporary
  dir that is renamed on success, and refuse to overwrite an existing
  release
- Skip the nightly deploy for non-snapshot versions in a version job
  that runs before the build, so merging a release PR no longer adds
  the release to the nightly composite
- Leave the javax tags (v<version>.javax) and release candidates to a
  follow-up

Part of: eclipse-glsp/glsp#1823
- Publish the client packages under the latest dist-tag when a release
  tag is pushed, after checking that it is a final release tag matching
  client/package.json, signed and verified by GitHub, and that CI passed
  on the tagged commit
- Skip next publishes of release versions, they publish from their tag
- Remove publish-release.yml, `glsp releng release` replaces it and
  creates the GitHub release itself
- Trigger the release workflows only for final release tags, so release
  candidate tags no longer start them and fail
- Point to re-running a cancelled or failed CI run when the CI check of
  a release fails

Part of: eclipse-glsp/glsp#1823
@tortmayr
tortmayr merged commit a7254f4 into master Nov 10, 2026
4 checks passed
@tortmayr
tortmayr deleted the deploy-release-mode branch November 10, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant