Repository navigation
GLSP-1823: Publish releases on push of their signed tag - #150
Merged
Merged
Conversation
- Add a Release workflow that runs when the tag v<version> is pushed. Before publishing it checks that the tag is a final release (v<major>.<minor>.<patch>) matching the server pom version, that it is signed and verified by GitHub, and that the server CI passed on the tagged commit - Upload the p2 repository to releases/<version> through a temporary dir that is renamed on success, and refuse to overwrite an existing release - Skip the nightly deploy for non-snapshot versions in a version job that runs before the build, so merging a release PR no longer adds the release to the nightly composite - Leave the javax tags (v<version>.javax) and release candidates to a follow-up Part of: eclipse-glsp/glsp#1823
5 of 7 tasks
- Publish the client packages under the latest dist-tag when a release tag is pushed, after checking that it is a final release tag matching client/package.json, signed and verified by GitHub, and that CI passed on the tagged commit - Skip next publishes of release versions, they publish from their tag - Remove publish-release.yml, `glsp releng release` replaces it and creates the GitHub release itself - Trigger the release workflows only for final release tags, so release candidate tags no longer start them and fail - Point to re-running a cancelled or failed CI run when the CI check of a release fails Part of: eclipse-glsp/glsp#1823
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Publishes a release from GitHub Actions when its signed tag
v<version>is pushed, replacing the dispatch from the umbrella release workflow.glsp releng release(eclipse-glsp/glsp-core#41) pushes this tag once the release PR is merged and CI passed on the release commit, and creates the GitHub release itself.v<major>.<minor>.<patch>. Before publishing it checks that the tag is a final release (v<major>.<minor>.<patch>) matching the server pom version, that it is signed and verified by GitHub, and thatci-server.ymlpassed on the tagged commitreleases/<version>through a temporary dir that is renamed on success, and refuse to overwrite an existing releaselatestfrompublish.ymlon the same tag push, with the same tag and CI checks againstclient/package.jsonandci.yml. Publishing stays inpublish.ymlbecause npm trusted publishing is bound to the workflow file, and the manual dispatch stays available as a fallback.nextpublishes skip release versionspublish-release.yml, which dispatched the umbrella workflowPart of: eclipse-glsp/glsp#1823
How to test
The release jobs run for the first time with the next real release. The build and upload steps mirror the nightly deploy job, which already runs green.
v2.8.0) and a lightweight tag are rejected, signed tags passFollow-ups
v<version>.javax) and release candidatesv*tagsprepare-release.ymlafter the first release with the new flowrelease.ymlanddeploy.ymlinto a local composite actionChangelog