Repository navigation
GLSP-1828: Fix model initialization never completing in IdeActionDispatcher - #153
Merged
Merged
Conversation
…atcher Since glsp-server#283 client requests go through ActionDispatcher.request(), so the SetModelAction answering the initial RequestModelAction is intercepted in dispatch() and never reaches runAction(). IdeActionDispatcher only notified the ModelInitializationConstraint there, so onceModelInitialized() never completed. - Notify the constraint about intercepted responses as well - Guard the constraint check with a lock, as intercepted responses arrive on the calling thread instead of the dispatcher thread. The future is completed outside the lock so onInitialized() callbacks cannot deadlock with a concurrent notification - Introduce a server/tests module with a Tycho test fragment for org.eclipse.glsp.ide.editor, run as part of `mvn clean verify` - Add JUnit 5 to both target platforms. r2025-12 pulls 5.11.4 from the 2025-03 release because the Tycho 4.0.8 surefire provider cannot run JUnit 5.12+ - Add a regression test for the intercepted SetModelAction Fixes eclipse-glsp/glsp#1828
tortmayr
force-pushed
the
fix-model-initialization-intercepted-response
branch
from
November 17, 2026 16:04
ec227e3 to
45c2ba3
Compare
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Since eclipse-glsp/glsp-server#283 client requests go through
ActionDispatcher.request(), so theSetModelActionanswering the initialRequestModelActionis intercepted as a pending response and never reachesrunAction().IdeActionDispatcheronly notified theModelInitializationConstraintthere, soonceModelInitialized()never completed.interceptPendingResponse()inIdeActionDispatcherto also notify the constraint about intercepted responsesserver/testsmodule with a Tycho test fragment fororg.eclipse.glsp.ide.editor, run as part ofmvn clean verifyr2025-12pulls 5.11.4 from the 2025-03 release because the Tycho 4.0.8 surefire provider cannot run JUnit 5.12+IdeActionDispatcherTestwith a regression test for the interceptedSetModelActionFixes eclipse-glsp/glsp#1828
How to test
initializesWhenSetModelAnswersModelRequesttimes out without the fix inIdeActionDispatcherIdeActionDispatcherdispatching aSelectActioninonceModelInitialized()selects the element once the diagram is openFollow-ups
2.8.0.javaxlineIdeMessageUtil,GLSPEditorRegistry,UrlUtils) in a separate PRr2025-12target can use its own JUnit versionChangelog