Repository navigation
Land cache memo, lock and tags in feature/caches and consolidate the cache ADR - #312
Merged
Merged
Conversation
…and async with errors
…ck on tagged cache
# Conflicts: # docs/adr/AGENTS.md
# Conflicts: # docs/adr/AGENTS.md
# Conflicts: # docs/adr/AGENTS.md
Cache.lock(): atomic locks for array, file and database stores
Cache.tags(): namespaced tagged cache with tagged flush
Cache.lock(): Redis lock
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#307, #309 and #310 were merged into their stacked parent branches (task/cache-memo and task/cache-lock), so Cache.lock, Cache.tags and the Redis lock never reached feature/caches. Only #306 (Cache.memo) did.
What
Content verification (against this branch)
I also checked each PR's added lines (#305, #306, #309 and #310) against this tree: every line is present. The misses in #296–#303 and #307 are all lines that later commits deliberately rewrote, such as the unittest test rewrite, the DB encode() helper, the Redis config and ADR text updates.
Validation
Supersedes #311.