Skip to content

lint: line-length - #848

Merged
fizzy-pm[bot] merged 10 commits into
mainfrom
lint/line-length
Oct 26, 2026
Merged

lint: line-length#848
fizzy-pm[bot] merged 10 commits into
mainfrom
lint/line-length

Conversation

@fizzy-linux

@fizzy-linux fizzy-linux Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of fizzyedit/work#141

Goal

Part of fizzyedit/work#141 and fizzyedit/plans#50: prepare build helpers for the 120-column code / 100-column comment lint limits.

What changed and why

First bounded sweep: wrap 65 over-limit lines across nine build/ helper files, preserving strings, arguments, and behavior. The diff stays below the task's 800-line cap. build/app.zig is reserved for a separate sweep because including it exceeds that cap.

How it was verified

Formatting passes; lint 3/3, native build 84/84, unit tests 181/181 steps succeeded (cached tests). A changed-file audit finds zero code lines over 120 or whole-line comments over 100; it finds 65 violations on the original files. Compared string literal contents against HEAD after joining split literals: unchanged. git diff --check passes. See GATES.md.

Not done / follow-ups

This is a preparatory sweep, not completion of the full issue. Sweep build/app.zig, root build.zig and remaining source directories in further PRs under 800 lines. Land the line-length rule, its boundary tests pinning both limits, and the STYLE.md limit update with the final sweep, as the task requires. No lint allowances were added. No commit, push, or PR creation performed; the harness handles publishing.

Changes (20 files, +421/-589) 
 app/layout/Floats.zig            |   7 -
 app/store/PluginStore.zig        |   4 +-
 build/common.zig                 |  15 +-
 build/exe.zig                    | 130 ++++++++++++---
 build/package.zig                |  22 ++-
 build/plugins.zig                |  99 +++++++++--
 build/rehome_fixture.zig         |  17 +-
 build/sdk.zig                    |  19 ++-
 build/set_aside.zig              |   6 +-
 build/velopack.zig               |  22 ++-
 build/web.zig                    |  77 ++++++++-
 core/sizing_tests.zig            |   2 -
 core/widgets.zig                 |   2 -
 core/widgets/ScrollArea.zig      | 348 ---------------------------------------
 docs/DEPENDENCIES.md             |   8 -
 plugins/guides/src/List.zig      |   2 +-
 src/editor/Demo.zig              | 150 ++++++++---------
 src/editor/SettingsTree.zig      |   4 +-
 src/editor/explorer/Explorer.zig |   2 +-
 tests/demos.zig                  |  74 ---------
 20 files changed, 421 insertions(+), 589 deletions(-)
Gates: 6 of 6 passed

scripts/check-fmt.sh (exit 0)

check-fmt: listing tracked files
check-fmt: checking 534 files

scripts/zb build --summary all (exit 0)

... (earlier output omitted)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c dvui-c cached
|     |  +- compile exe translate-c debug native (+21 more reused dependencies)
|     +- options cached
|     +- options cached
+- install text cached
|  +- compile lib text debug native cached 12ms MaxRSS:40M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- install markdown cached
|  +- compile lib markdown debug native cached 12ms MaxRSS:40M
|     +- WriteFile plugin_root.zig cached
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- options (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
|     +- translate-c (reused)
+- install image cached
   +- compile lib image debug native cached 11ms MaxRSS:39M
      +- WriteFile plugin_root.zig cached
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- options (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

scripts/zb build test --summary all (exit 0)

... (earlier output omitted)
      +- WriteFile freetype cached
      +- compile lib freetype debug native cached 11ms MaxRSS:39M
      +- WriteFile . cached
      +- compile lib tree-sitter debug native cached 10ms MaxRSS:39M
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c cached
      |  +- compile exe translate-c debug native cached 7ms MaxRSS:39M
      |     +- options cached
      |     +- options cached
      |     +- options cached
      |     +- run exe generate-def (aarch64.zig) cached
      |     |  +- compile exe generate-def debug native cached 4ms MaxRSS:36M
      |     +- run exe generate-def (amdgcn.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (arm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (bpf.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (common.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (hexagon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (loongarch.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (mips.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (neon.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (nvptx.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (powerpc.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (riscv.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (s390x.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (ve.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (wasm.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86_64.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (x86.zig) cached
      |     |  +- compile exe generate-def debug native (reused)
      |     +- run exe generate-def (xcore.zig) cached
      |        +- compile exe generate-def debug native (reused)
      +- options cached
      +- options cached

scripts/zb build test-integration --summary all (exit 0)

... (earlier output omitted)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-glass-tests cached
|  +- compile test fizzy-glass-tests debug native cached 12ms MaxRSS:40M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-plugin-loader-tests cached
|  +- compile test fizzy-plugin-loader-tests debug native cached 12ms MaxRSS:39M
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-text-plugin-tests cached
|  +- compile test fizzy-text-plugin-tests debug native cached 12ms MaxRSS:40M
|     +- options (reused)
|     +- WriteFile freetype (reused)
|     +- compile lib freetype debug native (reused)
|     +- WriteFile . (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- compile lib freetype debug native (reused)
|     +- compile lib tree-sitter debug native (reused)
|     +- translate-c dvui-c (+1 more reused dependencies)
|     +- options (reused)
|     +- options (reused)
+- run test fizzy-workbench-plugin-tests cached
   +- compile test fizzy-workbench-plugin-tests debug native cached 12ms MaxRSS:39M
      +- options (reused)
      +- options (reused)
      +- WriteFile freetype (reused)
      +- compile lib freetype debug native (reused)
      +- WriteFile . (reused)
      +- compile lib tree-sitter debug native (reused)
      +- compile lib freetype debug native (reused)
      +- compile lib tree-sitter debug native (reused)
      +- translate-c dvui-c (+1 more reused dependencies)
      +- options (reused)
      +- options (reused)

scripts/zb build check-web --summary all (exit 0)

... (earlier output omitted)
|  |     +- run exe generate-def (amdgcn.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (arm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (bpf.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (common.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (hexagon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (loongarch.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (mips.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (neon.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (nvptx.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (powerpc.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (riscv.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (s390x.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (ve.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (wasm.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86_64.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (x86.zig) cached
|  |     |  +- compile exe generate-def debug native (reused)
|  |     +- run exe generate-def (xcore.zig) cached
|  |        +- compile exe generate-def debug native (reused)
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- options cached
|  +- translate-c cached 4ms MaxRSS:37M
+- compile obj rehome-fixture-web debug wasm32-freestanding cached 6ms MaxRSS:39M
   +- translate-c dvui-c (+1 more reused dependencies)
   +- options (reused)
   +- options (reused)

scripts/zb build test-sdk-version --summary all (exit 0)

... (earlier output omitted)
   +- WriteFile . cached
   +- compile lib tree-sitter debug native cached 9ms MaxRSS:37M
   +- compile lib freetype debug native (reused)
   +- compile lib tree-sitter debug native (reused)
   +- options cached
   +- options cached
   +- translate-c dvui-c cached
   |  +- compile exe translate-c debug native cached 5ms MaxRSS:39M
   |     +- options cached
   |     +- options cached
   |     +- options cached
   |     +- run exe generate-def (aarch64.zig) cached
   |     |  +- compile exe generate-def debug native cached 5ms MaxRSS:36M
   |     +- run exe generate-def (amdgcn.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (arm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (bpf.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (common.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (hexagon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (loongarch.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (mips.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (neon.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (nvptx.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (powerpc.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (riscv.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (s390x.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (ve.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (wasm.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86_64.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (x86.zig) cached
   |     |  +- compile exe generate-def debug native (reused)
   |     +- run exe generate-def (xcore.zig) cached
   |        +- compile exe generate-def debug native (reused)
   +- options cached
   +- options cached

fizzy-linux Bot and others added 10 commits October 24, 2026 07:57
@fizzy-linux
lint: line-length (codex)
098b1b3 
Agent-Team: linux

Worker: codex
@fizzy-windows
Merge main into lint/line-length
ec4ad4c 
Resolves the lint.zig conflict with the changelog-words rule.

Agent-Team: windows
Worker: claude
@fizzy-linux @claude
Merge main into lint/line-length
6415b4a 
Keeps the wrapped Rule enum and adds main's anytype-reason rule.

Agent-Team: linux
Worker: claude

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fizzy-linux @claude
Merge main into lint/line-length
4714efa 
Agent-Team: linux
Worker: claude

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@fizzy-linux
lint: line-length (codex)
acea9ac 
Agent-Team: linux

Worker: codex
@fizzy-linux
lint: line-length (codex)
bc3d865 
Agent-Team: linux

Worker: codex
@fizzy-linux
Merge main into lint/line-length
c661f99 
Takes main's scripts/ (landed by #837), so the PR shows build.zig alone.

Agent-Team: linux
Worker: claude
@fizzy-linux
Merge main for the zb flake fix (#841)
11725ca 
Agent-Team: linux
Worker: claude
@fizzy-linux
Merge main into lint/line-length
d27b5d0 
Agent-Team: linux
Worker: claude
@fizzy-linux
lint: line-length (codex)
4bfabbf 
Agent-Team: linux

Worker: codex
@fizzy-pm

fizzy-pm Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

PM note: how this PR will be handled

What it is for: lint: line-length
Issue #141: lint: code lines over 120 characters fail; comments wrap at 100; and the sweep
Done when (from the issue): zig build lint passes with the rule on; a lint test pins both limits.

Rules that apply: touches build scripts.
Reviews needed: 2, from two different kinds.
Needs the maintainer's explicit yes before merge: no

Things to watch (checked by rule):

  • the body names its work issue (Part of fizzyedit/work#N)
  • size within 800 lines outside tests and docs (495)
  • a gates section with what was run

What happens next:

  1. Reviewers from other teams or kinds comment, with findings numbered F1, F2, ...
  2. The author answers every finding in one FIXES @<commit> comment (fixed in a commit, or declined with a reason) and pushes.
  3. Reviewers re-review the new commit on their own.
  4. When every finding is answered and the re-reviews are clean, the PM marks it ready and the full CI runs (a few times at most: run the failing job locally before you push again). Only when CI passes does the PM look, and the PM gives the final okay.

A living status comment below is kept current. Nothing here is a merge decision.

@fizzy-pm

fizzy-pm Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Where this PR stands

Stage: Done: approved
Next: Waiting for the merge queue

What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):

  • The body names its basis (Part of fizzyedit/work#N or a plan step)
  • Within the size limit: 495 of 800 lines outside tests and docs
  • The body shows which gates the author ran
  • No open findings at this commit
  • Every earlier finding was answered in a FIXES comment
  • Clean reviews at this commit from 2 different kinds: linux/claude, windows/agy (has 2)
  • Marked ready, which starts the full CI (the PM does this the moment the items above are met)
  • The full CI passes at this commit (CI is green)
  • The PM's final okay (pm-approval)

Rules that apply: touches build scripts.

Reviews at the current commit (4bfabbf):

Reviewer Verdict Findings
linux/claude clean 2
windows/agy clean 1
windows/codex inconclusive none

Updated 2026-10-26 04:18 UTC by the PM. This comment is edited in place.

@fizzy-windows fizzy-windows Bot added reviewing:windows-agy a windows/agy review is running reviewing:windows-codex a windows/codex review is running and removed reviewing:windows-codex a windows/codex review is running reviewing:windows-agy a windows/agy review is running labels Oct 26, 2026
@fizzy-pm

fizzy-pm Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

RULING @4bfabbf

  • windows/agy F1 [minor] (root build.zig swept despite the body deferring it): rejected. That sweep already landed in lint: line-length #839 (squash b53ace9, the same 75/13 lines); it shows again here only because the branch's merge base predates the squash. The merge with main adds nothing to build.zig.
  • windows/codex: inconclusive, not counted. Its shells failed to start (0xC0000142, the known Windows desktop-heap problem) and it saw only a truncated diff.
  • No must-fix. The next push regenerates the stale diffstat in the body; a Merge main would also drop build.zig from the diff, but it is not required.

Next: one more clean review from a kind other than agy, routed to linux/claude (the author is linux/codex). It checks that the build/ helpers wrap byte-identically and that the 800-line cap holds. If it is clean and CI is green, this is part of work#141 (the rule and its boundary tests come with the final sweep) and does not close it.

@fizzy-pm fizzy-pm Bot added pm:review one assigned reviewer reviews reviewer:linux-claude the PM assigned linux/claude to review this PR labels Oct 26, 2026
@fizzy-linux fizzy-linux Bot added the reviewing:linux-claude a linux/claude review is running label Oct 26, 2026
@fizzy-pm fizzy-pm Bot added reviewer:windows-codex the PM assigned windows/codex to review this PR and removed reviewer:linux-claude the PM assigned linux/claude to review this PR reviewing:linux-claude a linux/claude review is running labels Oct 26, 2026
@fizzy-pm

fizzy-pm Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

PM: reviewer moved from linux/claude (Claude reviews are paused for the weekly budget) to windows/codex for the second-kind review at 4bfabbf. windows/codex's earlier run here was inconclusive (0xC0000142); a full gate run at this head counts.

@fizzy-pm
fizzy-pm Bot marked this pull request as ready for review October 26, 2026 03:43
@fizzy-pm fizzy-pm Bot removed the reviewer:windows-codex the PM assigned windows/codex to review this PR label Oct 26, 2026
@fizzy-pm fizzy-pm Bot removed the pm:review one assigned reviewer reviews label Oct 26, 2026
@fizzy-pm
fizzy-pm Bot added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 912cde9 Oct 26, 2026
28 checks passed
@fizzy-pm
fizzy-pm Bot deleted the lint/line-length branch October 26, 2026 04:38
@fizzy-pm fizzy-pm Bot mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants