Repository navigation
fix(toolbox): upgrade pip so its vendored certifi is not the CRITICAL - #87
Merged
Merged
Conversation
GHSA-6q48-6c7w-9gw2 (CRITICAL): certifi bundles emSign root CAs whose intermediate keys were compromised. Fixed in certifi 2026.10.19. The vulnerable copy is pip's vendored one, which `pip install` cannot reach. Three different versions were in play, which is what made this confusing to read off a Trivy table: site-packages/certifi 2026.10.19 already fine, resolves on its own pip/_vendor/certifi 2026.6.17 from the python base layer, flagged pip 26.2.2 vendors certifi 2026.10.19, so this is a fix and not a VEX exception. .trivy/toolbox.openvex.json already states the rule: a fixable finding is fixed, not excepted. Done in the base final stage because all five domain images inherit FROM ${BASE}, and the vulnerable copy came from the shared python layer rather than from anything they install. Pinned as ARG PIP_VERSION with a tools.lock row rather than a bare --upgrade, so the drift gate tracks it and apply-tool-bumps.py can move it later: arg_name("pip") is PIP_VERSION, which matches the applier's convention. Verified: base reports pip 26.2.2 with vendored certifi 2026.10.19 and all four scanners still run. A derived skill-audit image built on it has BOTH copies at 2026.10.19, so the fix survives FROM and the derived pip install does not pull an older certifi into site-packages, which would have moved the finding rather than removed it. Drift check reports pip up to date. No changelog entry, matching #75 and #62, the two previous CVE unbreak-main fixes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
garymike
added a commit
that referenced
this pull request
Oct 21, 2026
…ublished (#88) Fourth time today the five reusable-workflow digest pins went stale, so the manual step gets a control. #73 made those pins deliberate on purpose: a rebuild must not silently change what every caller scans with, after betterleaks 1.6.1 -> 1.8.1 in #64 turned green repos red overnight. The cost of "deliberate" is that nothing moves them for you, and nothing reminded anyone either. #80 bumped eight tools and #81 bumped SkillSpector, both published, neither moved the pins, and callers kept getting the previous toolchain while tools.lock said otherwise. #82 was the cleanup. Every toolbox/** change since has put them behind again, including #87 and #86. Each build job now records the digest it published, and a new `pins` job compares those against the pin in the matching reusable workflow. Two design points that are the whole reason this works: It is a SEPARATE job, after base and domain, so publishing is never blocked. It cannot be blocked: the digest to pin does not exist until the publish has happened, so failing the publish on a stale pin would be circular. The images ship, and the run still goes red, so the follow-up is not optional. Same contract as tool-drift.yml: red means a pin is behind, not that anything is broken. It reads steps.build.outputs.digest rather than the registry. Comparing against the `latest` index digest false-reds on images whose index carries attestations, which is exactly why I pulled the equivalent check back out of check-tool-updates.sh in #82 rather than ship a flaky gate. The build already holds both halves, so no lookup and no ambiguity. mcp-review-toolbox is built here but no reusable workflow pins it, so it is reported as unpinned rather than counted as a mismatch. Verified by running the comparison standalone against three scenarios: all pins matching exits 0; two behind exits 1 with both named in ::error:: and marked in the job summary; and no digest files at all exits 1 saying the pins were NOT verified, rather than passing quietly, which is the failure mode that let this go unnoticed in the first place. actionlint clean, zizmor clean. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
garymike
added a commit
that referenced
this pull request
Oct 21, 2026
…hed (#89) The first refresh prompted by the check rather than by remembering. #88 added a `pins` job to build-toolbox.yml; its own merge triggered a rebuild, the job ran, and it went red naming all five stale pins with the digest each should move to. A true positive on first firing, because #86 and #87 had already left them behind. security-toolbox-base d2f1d6b33d9c -> 9be060794ecb gha-toolbox 7e6558f3b46c -> 4cef3443acbd sast-toolbox 6bf6d9aafd5a -> edfd4db8752a iac-toolbox bc4198b93fcc -> 08e1338df20c skill-audit-toolbox c10bc17412a2 -> f5f99b96668f Digests taken from the job's own annotations, which report steps.build.outputs.digest from the run that published them. No local pull and no registry lookup, so neither the index-vs-manifest ambiguity from #82 nor a hand-copied digest can get in. Verified behind the new pins: base ships trufflehog 3.99.3, betterleaks 1.9.0, osv-scanner 2.7.0 and syft 1.55.0, with pip 26.2.2 vendoring certifi 2026.10.19, so #87's CVE fix is actually in what callers now get. skill-audit ships SkillSpector v2.13.0. One thing the check cannot currently survive: #86's build failed on a cosign/Rekor 409, "an equivalent entry already exists in the transparency log", because toolbox/gha was unchanged so gha-toolbox rebuilt to a byte identical digest that was already signed. A failed domain arm skips the pins job rather than running it. Benign cause, but it means a reproducible rebuild can silence the check. Noted, not fixed here. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks the Trivy publish gate. It is currently failing on every build, which is what blocks #86.
Why the Trivy table was misleading
Three different certifi versions were in play, so the reported
2026.6.17matched nothing I could find by hand:site-packages/certifi2026.10.19pip/_vendor/certifi2026.6.17main's published image, site-packages2026.10.18The vulnerable copy is the one pip vendors for its own HTTPS to PyPI.
pip installcannot reach it, which is why nothing intools.lockwould have fixed this.A fix, not an exception
pip 26.2.2 vendors
certifi==2026.10.19, the patched release, and26.2.2is current on PyPI..trivy/toolbox.openvex.jsonalready states the rule this follows: a fixable finding is fixed, not excepted. That reasoning is in the Dockerfile comment so the next reader does not have to rediscover why this is not a VEX entry.Placement and pinning
In the base final stage, because all five domain images inherit
FROM ${BASE}and the vulnerable copy came from the sharedpython:3.14-slimlayer rather than from anything they install. One place instead of five.Pinned as
ARG PIP_VERSION=26.2.2with atools.lockrow rather than a bare--upgrade pip, which keeps house style and plugs into the existing machinery:check pip "$(pinned pip)" "$(pypi_latest pip)"added, and the gate now reportspip: up to date (26.2.2)arg_name("pip")resolves toPIP_VERSION, soapply-tool-bumps.pycan move it on a future bump instead of this becoming another pin that only moves by handVerification
pip 26.2.2, vendoredcertifi==2026.10.19, and all four scanners still report versions, so the upgrade did not break the imageskill-auditimage built on it has both certifi copies at2026.10.19. That was the check worth doing: if the derivedpip installhad pulled an older certifi into site-packages, the finding would have moved from the vendored copy to the real one rather than being removed.SkillSpector v2.13.0andsemgrep 1.181.0both still run.Scope
No changelog entry, matching #75 and #62, the two previous CVE unbreak-main fixes. That also keeps this off
CHANGELOG.mdso it does not conflict with #86's1.7.1entry.Nothing here touches detection behaviour. #86 should go green once this lands and its build re-runs.
🤖 Generated with Claude Code