http surface for subclassed IncomingMessage and ServerResponse by puskuruk · Pull Request #4 · geastack/node-compat

puskuruk · 2026-10-19T03:05:43Z

What @nestjs/platform-node needs from node:http, node:net and URL: ServerOptions.IncomingMessage/ServerResponse constructors, ServerResponse<Req> with req, URL.canParse defined through the constructor, absent headers reading as undefined, and socket readable/writable flags that on-finished reads, on net.Socket and on the HTTP server's own req.socket.

a764850 Make http.ServerResponse generic over its IncomingMessage and expose req
94f7625 Honour ServerOptions.IncomingMessage and ServerOptions.ServerResponse constructors in createServer
b753a7f Add URL.canParse to the compiled WHATWG URL class
4860248 Cover ServerResponse subclassing through ServerOptions and URL.canParse with node-vs-compiled parity tests
5fc7133 Type IncomingMessage headers as string | undefined so a header the request did not send reads as undefined, with a dictionary-missing parity test
7e9691b Maintain net.Socket's readable and writable flags across connect, end, peer end and destroy, as the on-finished shim reads them
54dd13d Build hono-bridge's Request headers from the header values the request carries, now that an absent IncomingMessage header reads as undefined
230e902 Report an accepted HTTP connection's socket as open, and closed once destroyed
bdcd9e1 Throw ERR_INVALID_URL from the URL constructor and define canParse through it
390ebf5 Drop the deviations the typed request surface removed from the README
579b980 Assert the dictionary probe matches Node line for line, on compiler 1.0.47 or newer

Verification on 579b980 (compiler 1.0.47): HTTP_SERVER_OPTIONS_PARITY_OK:5, URL_CAN_PARSE_PARITY_OK:170, DICTIONARY_MISSING_PARITY_OK:22; full sweep green (hono-hello build, test-hono, fastify, 31 scripts).

test-dictionary-missing.mjs compares the compiled probe with Node line for line. The two lines it used to record as a compiler gap (a missing key of a { [k: string]: string } map under typeof and ??) match since compiler 1.0.47 (geastack/compiler#15), so the compiler requirement moves from ^1.0.43 to ^1.0.47 (peer, dev, lockfile): the floor the parity holds from.

1. http.Socket readable/writable: fixed in 5d61c70. An accepted connection's socket now sets readable/writable to true (runtime/node/http.ts:316). destroy() sets both back to false (:353). req.socket.writable is true for a live response, so on-finished no longer treats it as finished.

2. Dictionary test passing over a miscompile: fixed in 7bbff81. The skip set is gone. The two lines are a compiler gap: a missing key of { [k: string]: string } reads as "" under typeof and ??, where Node gives undefined. The test now:

asserts each gap's exact compiled line and prints it as KNOWN GAP
reports DICTIONARY_MISSING_MATCHED:20 KNOWN_GAPS:2 instead of PARITY_OK
fails with "now matches Node; remove it from knownGaps" once a compiler gets it right

The gap is still there on 1.0.43 and 1.0.46. geastack/compiler#15 fixes both lines, and with it the test is 22/22.

3. URL.canParse vs the constructor: fixed in 0410f6c. The validation is in the constructor's parse, which throws Node's TypeError with code: 'ERR_INVALID_URL', input and base. canParse is try { new URL(url, base); return true } catch { return false }, so new URL('http://a<b') throws and canParse returns false. The probe now has a constructor-outcome table over the same inputs (URL_CAN_PARSE_PARITY_OK:170).

4. Cleanups: done in 5d61c70.

serverResponseClass_ keeps its undefined default because the compiler refuses to carry the generic ServerResponse class as a value (native-boundary:uncensused-class-object). A comment there says so.
The stale "placeholder socket (connId 0)" text is gone from loadPeer.

Verification on 7bbff81 with compiler 1.0.43: full sweep green, including HTTP_SERVER_OPTIONS_PARITY_OK:5, URL_CAN_PARSE_PARITY_OK:170, STREAM_LIFECYCLE_PARITY_OK:27 and ZLIB_STREAMS_PARITY_OK:65.

… constructors in createServer

…se with node-vs-compiled parity tests

…quest did not send reads as undefined, with a dictionary-missing parity test

…, peer end and destroy, as the on-finished shim reads them

…t carries, now that an absent IncomingMessage header reads as undefined

…destroyed net.Socket's constructor leaves a handle `opening`, neither readable nor writable, and only its own connect path flips those; http.Socket called `super()` and never did, so a live request's `req.socket.writable` read false and on-finished treated every response as already finished. A Socket built for an accepted connection now reports what net.Socket reports once connected, and `destroy()` reverses it the way net.Socket's does. `serverResponseClass_` keeps its undefined default and now says why: the compiler refuses to carry the generic `ServerResponse` class as a value (`native-boundary:uncensused-class-object`). The `loadPeer` comment no longer refers to a module-load-time placeholder socket that does not exist.

…rough it The constructor's minimal parse accepted any text, while `URL.canParse` was a separate validator, so the two could disagree. The validation now runs in the constructor, which throws Node's `TypeError: Invalid URL` with `code`, `input` and `base`, and `canParse` is what Node defines it as: the constructor does not throw. The probe prints a constructor-outcome table over the same inputs as the canParse table.

`res.req` exists, and a `req.headers` value is a string or undefined rather than a plain string; the set-cookie deviation stays.

….0.47 or newer `test-dictionary-missing.mjs` recorded two compiler gaps as known: a missing key of a `{ [k: string]: string }` map read as `""` under `typeof` and `??`, where Node reads `undefined`. Compiler 1.0.47 (geastack/compiler#15) observes the absence at both, and with it the compiled probe matches Node on every one of its 22 lines. The known-gap map and its bookkeeping go; the test compares each line and names the three probe lines it exists for. The parity holds from 1.0.47, so `@geastack/compiler` moves from `^1.0.43` to `^1.0.47` in both the peer and the dev dependency, and the lockfile follows.

puskuruk · 2026-10-24T20:28:27Z

Rebased on main 3d53505 (after #12 and the 1.0.21 release). Head is now 579b980.

Compiler 1.0.47 (geastack/compiler#15) closes both gaps the dictionary test recorded: with it the compiled probe matches Node on all 22 lines (DICTIONARY_MISSING_PARITY_OK:22), and the same test on 1.0.46 fails at line 3 as it should. The test now asserts line-for-line parity and the compiler requirement moves from ^1.0.43 to ^1.0.47 (peer, dev, lockfile), since that is the floor the parity holds from.

Full sweep on 579b980 with 1.0.47: hono-hello build, test-hono, both fastify tests and all 31 scripts exit 0 (DICTIONARY_MISSING_PARITY_OK:22, HTTP_SERVER_OPTIONS_PARITY_OK:5, URL_CAN_PARSE_PARITY_OK:170).

This was referenced Oct 19, 2026

Add fs.stat, fs.statSync and fs.promises.stat #2

Merged

Add setImmediate and clearImmediate #3

Merged

Add node:zlib streams and brotliDecompress #5

Merged

Nest 1/4: typed shims for platform-node's dependencies #6

Draft

puskuruk marked this pull request as ready for review October 19, 2026 03:19

puskuruk force-pushed the fix/http-surface-for-subclassed-request-response branch from 7b585fb to 05e4aaf Compare October 21, 2026 00:19

This was referenced Oct 21, 2026

Observe absence under typeof and ?? for index-signature reads geastack/compiler#14

Closed

Raise the @geastack/compiler floor to ^1.0.43 #10

Merged

puskuruk force-pushed the fix/http-surface-for-subclassed-request-response branch from 75da063 to 0555eea Compare October 21, 2026 04:26

This was referenced Oct 21, 2026

Observe absence for index-signature reads under typeof, ??, &&, ?. and unknown/any geastack/compiler#15

Merged

Follow Node's autoDestroy, write/end ordering and deferred 'end' in node:stream #11

Merged

puskuruk force-pushed the fix/http-surface-for-subclassed-request-response branch from 0555eea to 7bbff81 Compare October 24, 2026 08:36

puskuruk added 11 commits October 24, 2026 21:46

Make http.ServerResponse generic over its IncomingMessage and expose req

a764850

Honour ServerOptions.IncomingMessage and ServerOptions.ServerResponse…

94f7625

… constructors in createServer

Add URL.canParse to the compiled WHATWG URL class

b753a7f

Cover ServerResponse subclassing through ServerOptions and URL.canPar…

4860248

…se with node-vs-compiled parity tests

Type IncomingMessage headers as string | undefined so a header the re…

5fc7133

…quest did not send reads as undefined, with a dictionary-missing parity test

Maintain net.Socket's readable and writable flags across connect, end…

7e9691b

…, peer end and destroy, as the on-finished shim reads them

Build hono-bridge's Request headers from the header values the reques…

54dd13d

…t carries, now that an absent IncomingMessage header reads as undefined

Drop the deviations the typed request surface removed from the README

390ebf5

`res.req` exists, and a `req.headers` value is a string or undefined rather than a plain string; the set-cookie deviation stays.

puskuruk force-pushed the fix/http-surface-for-subclassed-request-response branch from 7bbff81 to 579b980 Compare October 24, 2026 20:28

Navigation Menu

Repository navigation

http surface for subclassed IncomingMessage and ServerResponse - #4

http surface for subclassed IncomingMessage and ServerResponse#4
puskuruk wants to merge 11 commits into
mainfrom
fix/http-surface-for-subclassed-request-response

puskuruk commented Oct 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Uh oh!

puskuruk commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

puskuruk commented Oct 24, 2026

Uh oh!

puskuruk commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

puskuruk commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Uh oh!

puskuruk commented Oct 20, 2026

Uh oh!

coderabbitai Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puskuruk commented Oct 24, 2026

Uh oh!

puskuruk commented Oct 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

puskuruk commented Oct 19, 2026 •

edited

Loading

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

coderabbitai Bot commented Oct 20, 2026 •

edited

Loading