Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 19, 2026
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 19, 2026 20:25
368dcf1 to
d5a4a03
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 19, 2026 20:25
5d218b9 to
be6383d
Compare
Collaborator
Author
|
@coderabbitai review |
|
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 20, 2026 04:33
d5a4a03 to
042166f
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
2 times, most recently
from
October 23, 2026 01:48
beb3f1d to
aeb89ff
Compare
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 23, 2026 01:48
042166f to
10329f6
Compare
…s HTTPMethod (UPSTREAM-DIFF)
…pt source has no default export (UPSTREAM-DIFF)
…ams, ParsedQuery, a NodeApp class, no prototype-reassigned params object (UPSTREAM-DIFF)
…certification, with qs's Decoder and a ParsedQs scanQuery in secure-json-parse (UPSTREAM-DIFF)
…from the pinned nest commit
…de-vs-compiled probes for JSON.stringify of undefined and instanceof over an Error subclass
puskuruk
force-pushed
the
nest/platform-node-shims
branch
from
October 23, 2026 09:17
10329f6 to
b9b72d5
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 23, 2026 09:17
aeb89ff to
6dbe313
Compare
Re-vendor the five platform-node files from nestjs/nest feat/platform-node at 0828b0d (2026-10-24, packages at 12.2.0; pinned before: 2b10fb2, 12.1.3), carrying the typing edits listed in UPSTREAM-DIFF.md onto the rewritten router (one find-my-way tree, path-to-regexp variants for trailing slashes, literal-prefix skips, empty-segment fallbacks) and the body parser. New edits the new upstream needs under geatsc, each listed in UPSTREAM-DIFF: the `METHODS` import of `http` aliased to this target's `httpMethods`; the variant matcher's `TokenData[]` stated as `Path[]` (no conversion into the `Path | Path[]` union otherwise); `Object.assign` onto the route parameters replaced by a key loop; a second `as any` matcher cast dropped. tools/nest/build-platform-node.mjs pins 0828b0d / 12.2.0 and nest-node-probe depends on the 12.2.0 tarballs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors the typed sources of
@nestjs/platform-nodeat nest commit 0828b0d (head of PR nestjs/nest#18063 on 2026-10-24, packages at 12.2.0) underruntime/node/nest, with the type-level edits whole-program strict certification needs, each listed inUPSTREAM-DIFF.md; upstream's comments are kept.tools/nest/build-platform-node.mjspacks the three@nestjstarballs from the pinned commit, andapps/nest-node-probecarries the Node oracle and two node-vs-compiled probes.The first eight commits vendor 2b10fb2 (12.1.3); the last moves to 0828b0d. Upstream rewrote the router in between (one find-my-way tree, path-to-regexp variants for trailing slashes, literal-prefix skips, empty-segment fallbacks) and fixed the body parser's decoder. The new upstream needs four more edits under geatsc, each in
UPSTREAM-DIFF.md: theMETHODSimport ofhttpaliased to this target'shttpMethods; the variant matcher'sTokenData[]stated asPath[];Object.assignonto the route parameters replaced by a key loop; a secondas anymatcher cast dropped. The publicRouteTablesurface the shims drive (add,lookup,PARAM_TOO_LONG) is unchanged.Verification on 2c9b517 with the published compiler 1.0.47:
node tools/nest/build-platform-node.mjs --check→ 3 tarballs at 0828b0d;tools/nestnpm run check→ 24 shim tables passed; all 33scripts/test-*.mjspass, includingERROR_SUBCLASS_PARITY_OK:8andJSON_UNDEFINED_PARITY_OK:7.Related
Stack: #6 (1/4, shims) → this PR → #8 (3/4, AOT) → #9 (4/4, benchmark). Shows only its own nine commits over
nest/platform-node-shims.