Repository navigation
Conversation
… route decorators with the checker into a generated module function
…ped shims the AOT-generated application drives
…ansform plugin in build.mjs
…inst its Node oracle over eleven requests
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 19, 2026
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 19, 2026 20:25
5d218b9 to
be6383d
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 19, 2026 20:25
16bf804 to
714d794
Compare
Collaborator
Author
|
@coderabbitai review |
|
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 20, 2026 04:33
be6383d to
beb3f1d
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 20, 2026 04:33
714d794 to
f6c7b52
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 23, 2026 01:48
beb3f1d to
aeb89ff
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 23, 2026 01:48
f6c7b52 to
00d3cba
Compare
puskuruk
force-pushed
the
nest/platform-node-vendor
branch
from
October 23, 2026 09:17
aeb89ff to
6dbe313
Compare
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 23, 2026 09:17
00d3cba to
2663870
Compare
… the adapter does hello-nest depends on the 12.2.0 tarballs the pinned builder now packs. The core shim follows 12.2.0's NodeAdapter exception mapping: an http-errors style client error (body parser, URI too long) becomes an HttpException with its status and message (the status text when it must not be exposed); a 5xx one stays unmapped and is answered as an unknown exception.
puskuruk
force-pushed
the
nest/aot-hello-nest
branch
from
October 25, 2026 16:20
2663870 to
df1a705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/hello-nest(a decorated controller onNodeAdapter,@nestjs/core12.2.0) compiles with geatsc.tools/nest/aotresolves@Module,@Controller,@Injectableand the route decorators with the TypeScript checker into a generated module function;scripts/build.mjsruns it as a compiler source-transform plugin, andreflect-metadataand the three@nestjspackages map to typed shims the generated application drives.The app was added on 12.1.3; the last commit moves it to the 12.2.0 tarballs of Nest 2/4 and ports 12.2.0's adapter exception mapping into the core shim: an http-errors style client error (body parser, URI too long) becomes an
HttpExceptionwith its status and message, a 5xx one stays an unknown exception.Builds with the published compiler 1.0.47, which carries the four fixes this needed (geastack/compiler#7 to geastack/compiler#10). The
package.jsonfloor is still^1.0.43; raising it is open.Verification on df1a705 with 1.0.47:
node scripts/test-hello-nest.mjs→HELLO_NEST_PARITY: 10 of 11 identical. The one deviation is theJSON.parseerror message wording onPOST /jsonwith a malformed body, which geastack/compiler#21 fixes: built with the compiler stack https://github.com/geastack/compiler/pull/22 the same app answers 11 of 11.tools/nestcheck 24 tables passed; the other 32scripts/test-*.mjspass.Benchmark
Same app under Node and compiled,
bench/http-matrix.py(Nest 4/4), 2026-10-25, arm64 Ubuntu 24.04 container on an 8-vCPU Colima VM (Apple M1), VM and host otherwise idle, compiler 1.0.47: 2 s warmup, 8 s samples,wrk -t4 -c64, three interleaved rounds, server on vCPUs 0-3, wrk on 4-7. Not the bench host, so compare ratios, not absolute sizes, across runs.//json//jsonGET /: compiled Nest 2.24× Nest on Node at one worker and 1.85× at four, 1.80× barenode:httpon Node, 0.86× compiled Hono; PSS 1/31; startup 12 ms against 498 ms and 924 ms. Binary 8,016,904 bytes. Raw records and the full ten-server table are in Nest 4/4.Related
Stack: #6 (1/4) → #7 (2/4) → this PR → #9 (4/4, benchmark harness and raw records). Parity 11 of 11 needs geastack/compiler#21 (stack https://github.com/geastack/compiler/pull/22).