Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/warden.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Warden
# Update the concurrency group below if this workflow adds non-PR triggers.
on:
pull_request:
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, ready_for_review]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruleset workflow ignores extra PR types

High Severity

This file is the org ruleset-required Warden workflow. GitHub ignores types on ruleset workflows and only runs them on opened, synchronize, and reopened. Adding ready_for_review does not start a run when a draft is marked ready, so repo skills gated on draft = false still skip those PRs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 33c7662. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. sentry-dotnet's Warden runs resolve to actions/required_workflows/244397820, which means they run as a ruleset workflow. The rulesets docs say a ruleset workflow ignores types and only ever runs on the default opened, synchronize, and reopened activity types. So this change has no effect, and there's no other value for types here that would make it work. I'm leaving the PR open until the requester decides whether to close it or take a different approach.


concurrency:
group: ${{ github.workflow }}-pr-${{ github.event.pull_request.number }}
Expand Down
Loading