Repository navigation
ci(warden): Run on ready_for_review - #229
sentry-junior[bot] wants to merge 1 commit into
Conversation
Draft PRs marked ready without a new push never trigger Warden, so skills gated on draft = false skip them entirely. Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33c7662. Configure here.
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| types: [opened, synchronize, reopened, ready_for_review] |
There was a problem hiding this comment.
Ruleset workflow ignores extra PR types
High Severity
This file is the org ruleset-required Warden workflow. GitHub ignores types on ruleset workflows and only runs them on opened, synchronize, and reopened. Adding ready_for_review does not start a run when a draft is marked ready, so repo skills gated on draft = false still skip those PRs.
Reviewed by Cursor Bugbot for commit 33c7662. Configure here.
There was a problem hiding this comment.
Confirmed. sentry-dotnet's Warden runs resolve to actions/required_workflows/244397820, which means they run as a ruleset workflow. The rulesets docs say a ruleset workflow ignores types and only ever runs on the default opened, synchronize, and reopened activity types. So this change has no effect, and there's no other value for types here that would make it work. I'm leaving the PR open until the requester decides whether to close it or take a different approach.
|
Closing. This is a ruleset-required workflow, so GitHub ignores |


The org Warden workflow only listens for
opened,synchronize, andreopened. When a draft PR is marked ready and nothing new is pushed, Warden never runs, so repo skills gated ondraft = falseskip the PR entirely. sentry-dotnet hit this on getsentry/sentry-dotnet#5930 and getsentry/sentry-dotnet#5932: both were opened as drafts and marked ready without a push, which is their normal process.This adds
ready_for_reviewto the workflow'spull_requesttypes. Warden already supports the action. Repos still need to list it in their skill triggers to act on it, and skills that don't list it won't match this event.The org
security-reviewtrigger stays as is. It has no draft filter, so it already runs when a draft is opened.One side effect: the concurrency group is per PR with
cancel-in-progress: true, so aready_for_reviewrun cancels asynchronizerun that is still going on the same PR. Both run against the same head, so this should be harmless.via Ricardo Oliveira.
--
View Session [Sentry]