Skip to content

ci(risk): Never label PRs touching high-risk files as low risk - #6643

Merged
runningcode merged 1 commit into
mainfrom
ci/pr-risk-high-risk-floor
Nov 17, 2026
Merged

runningcode merged 1 commit into
mainfrom
ci/pr-risk-high-risk-floor

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

.github/file-filters.yml already lists the files we treat as high risk: the transport classes, RateLimiter, and InternalSentrySdk, which hybrid SDKs use. "Changes In High Risk Code" comments on PRs that touch them, but the PR Risk (Jev) workflow never looks at that list. A PR that changes RateLimiter could still get risk: low.

Now the publish step raises a Jev low to risk: medium when the PR touches one of those files, and logs a notice naming them. Medium and high verdicts are left alone. Jev's own rubric says sensitive paths shouldn't decide the label on their own, so this applies the repo's policy after classification instead of changing the model input.

The filter is read from the PR's base revision, so a PR can't remove its own files from the list. The parser accepts exact paths only. If someone adds a glob, the job fails instead of silently missing it. file-filters.yml now has a comment saying so.

Open decision: medium vs. high as the minimum. I went with medium, since these files are only one signal. Changing it is a one-word edit.

Like any pull_request_target workflow, this runs from main, so it takes effect only after merge.

#skip-changelog

via no.

--

View Session [Sentry]

Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
@sentry

sentry Bot commented Nov 17, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

@runningcode
runningcode marked this pull request as ready for review November 17, 2026 15:20
@runningcode
runningcode requested review from a team and adinauer as code owners November 17, 2026 15:20
@runningcode
runningcode requested review from markushi and romtsn and removed request for a team November 17, 2026 15:20
@runningcode
runningcode merged commit 271bf34 into main Nov 17, 2026
48 of 49 checks passed
@runningcode
runningcode deleted the ci/pr-risk-high-risk-floor branch November 17, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant