Repository navigation
docs: migrate example app to material_ui - #795
Merged
Merged
Conversation
4 of 6 tasks
jokerttu
marked this pull request as ready for review
November 5, 2026 11:46
jokerttu
force-pushed
the
example-material-ui
branch
2 times, most recently
from
November 5, 2026 12:12
d366a50 to
f07eb08
Compare
jokerttu
force-pushed
the
example-material-ui
branch
from
November 5, 2026 14:38
f07eb08 to
a259a61
Compare
illuminati1911
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the example app to
package:material_ui, following the official migration guide. The plugin's own requirements are unchanged.example/pubspec.yamlrequiressdk: ^3.13.0andflutter: ">=3.47.0", the environmentmaterial_uideclares, and addsmaterial_ui: ^1.10.0.dart fix --apply --code=migrate_design_widgets. The example uses no Cupertino library and no localization delegates, so nothing else needed migrating.finalon a function parameter; one parameter innavigation.dartdrops it.CI
Run Dart analysis and unit tests on minimum Flutter, keeps checking the plugin on 3.44.x, the minimum in the rootpubspec.yaml. It runsflutter pub get --no-example,flutter analyze --no-pub lib test --fatal-infosandflutter test --no-pub. Native unit tests and builds now run on 3.47.x only.Stacked on #794.
Checks run
flutter analyze . --fatal-infosclean in the plugin and the example,dart formatreports no changes, 268 Dart tests pass.Map taps on iOS with Flutter 3.47. Flutter 3.47's iOS engine asks
PlatformDispatcher.onHitTestwhether a touch belongs to a platform view, and blocks the touch when no callback answers.GestureBindinginstalls that callback, butflutter_test'sTestPlatformDispatcherdoesn't forward it to the real dispatcher, so under Patrol every tap on the map was blocked, and botht06"Test map UI settings" variants failed. Thepatrol()wrapper inpatrol_test/shared.dartnow installs the same answerGestureBindinggives in an app. Apps aren't affected; this only changes the test binding. With it,t06_map_test.dartpasses 12/12 on the iOS 26.5 simulator with Flutter 3.47.9.Pre-launch Checklist