Skip to content

Sync upstream ade473018d into coder-only - #309

Merged
henrychu04 merged 304 commits into
coder-onlyfrom
t3code/sync-upstream-ade473018d
Nov 8, 2026
Merged

henrychu04 merged 304 commits into
coder-onlyfrom
t3code/sync-upstream-ade473018d

Conversation

@henrychu04

@henrychu04 henrychu04 commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Range

pingdotgg/t3code 337c5858c3..ade473018d (299 commits), merged into coder-only 779a1af in one stage (merge commit 46de7cc). Upstream's web redesign stack (pingdotgg#28839–pingdotgg#28845, maria/redesign/*) is not in the range. SYNC_BASE is now ade473018d.

Commits:

  1. 46de7cc578 Merge upstream/main ade4730 into coder-only (resolutions included)
  2. ad2095f579 Seams doc, DELETED_PATHS, SYNC_BASE, sync.md lessons
  3. 81b2d7c224 PR-watch !N test, Codex thread-config test, voice keybinding doc paragraph
  4. 8bc57d8a67 Bridge instructions rewrite for feat(server): html tools take a file path, so agents stop retyping pages pingdotgg/t3code#32833's wording; upstream tests adapted to the GitLab-only seams

Carried

Cut

New seams (all in docs/internals/coder-only.md)

Boundary notes

  • No upstream change in range removed fork behaviour that a boundary needs. No new query() options or SDK Query methods. No SDK, Node, or @types/node bumps. No new MCP-server path to providers (the only hits are in the uncarried McpHttpServer.ts).
  • The voice cut also keeps boundary 6 and the "composer attachments are the only laptop-to-workspace upload" rule intact.
  • The only new RPC upstream added to WsRpcGroup is provider.auth.removeMethod, which is not served, along with the rest of sign-in.

Verification

  • pnpm test:coder passes in all parts (run in foreground pieces): gateway/helper/coder-cli node tests, effect-codex-app-server, contracts (136), server (4156 passed, 1 skipped), providers, source control, client-runtime, shared, web unit (4029), web browser (569), knip-schemas test.
  • Every typecheck in AGENTS.md passes, as do pnpm build, pnpm knip:check, fmt --check over every file the sync changed, seams-check, and sync-check (unused-locals clean; marker drops and lost/both-sides lines reviewed and explained in the merge message).
  • Live smoke: a real local Coder 2.34.5 server with CLI 2.25.3, a fresh workspace container, and the helper installed over coder ssh from this build. It drove the gateway's loopback WebSocket with a fake kilo acp agent:
    • a turn completes, and the T3 bridge instructions reach the agent
    • a follow-up reuses the provider session
    • a /clear-style fresh send starts a new agent process and provider thread with freshContext: true
    • the thread settles
    • pullRequests.list answers (no glab in the test workspace, so no MR data)
    • server.getConfig reports freshContext and scheduledTaskThreadModes and no voice capability

Review follow-up

9c56c44d23 puts back pingdotgg#30623's Cmd/Ctrl+Enter submit in PullRequestReviewForm.tsx, which the voice revert had removed along with the speech hooks. commentSubmitShortcut.ts is upstream's again. Reverified on the new head: every typecheck, knip:check, seams-check, pnpm test:coder (web: 4029 unit and 569 browser tests) and pnpm build.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits November 5, 2026 15:30
…1654)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: UtkarshUsername <putkarsh184@gmail.com>
…0623)

Co-authored-by: UtkarshUsername <putkarsh184@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…31059)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#31642)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
pingdotgg#28487)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…#30453)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…gdotgg#27699)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…dotgg#27682)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ingdotgg#24983)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
… logins (pingdotgg#29825)

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
… iOS (pingdotgg#30139)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
)

Co-authored-by: SAPHID <saphid@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
arifali123 and others added 28 commits November 7, 2026 15:53
…#27941)

Co-authored-by: Orin <orin@orin.ws>
Co-authored-by: maria-rcks <maria@kuuro.net>
…s the thread (pingdotgg#28454)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gg#27541)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…etails card (pingdotgg#27582)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…in folders (pingdotgg#25883)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#32266)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#28255)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#26737)

Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…ges (pingdotgg#32833)

Agents can pass `path` to an absolute .html file instead of retyping the
page as inline `html`. The server reads the file only for full-access
threads, with the existing disk-read guards, and snapshots it at publish.
ACP render recovery matches path calls by path. The mcp-tool-use eval
grades pages passed by path.

Takes over pingdotgg#32817.

Co-authored-by: Stoli Geyer <stoli@tractorbeam.ai>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#32242)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: PR Batch Tester <agent@local.test>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…31379)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Bryan Tobing <bryantobing0@gmail.com>
…their own updater (pingdotgg#21524)

Mise-owned providers requested as latest now update with mise upgrade <tool>; pinned tools, version paths and mise x scripts stay manual.

Co-authored-by: Ryan Hughes <ryan@heyoodle.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Brings 299 upstream commits (337c585..ade4730): Claude Ultracode, fresh
sessions and /clear, scheduled tasks in one thread with fresh sessions and moving
them between threads, task thread links, auto-settle after 7 days and stopping
project actions on settle, the Labs tool-call visibility setting, PR comments in
chat, GitLab review/label/branch/reference/author features, #123/!123/@user
completion in PR composers, Pi extension status, deleting archived threads,
html_render file paths, mise provider updates, and server, orchestration-v2,
and client-runtime performance work (one projection per live event, batched
provider writes, PR action replies patching readers, on-demand provider
catalogs, output windowing for config/shell/thread streams).

Resolution:
- Voice input cut whole (pingdotgg#30623, pingdotgg#30624, pingdotgg#30625, pingdotgg#31769 and follow-ups):
  speech modules, settings, contracts fields and capabilities, and the
  dictation hooks in carried text fields were removed by reverting the voice
  commits file by file, keeping later PR-completion hunks.
- Secret-provider work cut (pingdotgg#31670, pingdotgg#31651, pingdotgg#31652's server parts, the
  pingdotgg#31226 hydration reload); pingdotgg#31226's registry parking, pingdotgg#30805, pingdotgg#31653 kept.
- Not carried: headless preview/html_preview, desktop/mobile/release/CI,
  managed policy and observability policy, managed Codex, service install,
  agent sign-in and sign-in method removal, other providers and forges,
  CLIProxy usage, and query persistence on web.
- TextGeneration keeps pingdotgg#29607's fallback from a provider that cannot run
  without the out-of-usage trigger.
- GitLab author links and reference autolinks are now upstream's (pingdotgg#30418,
  pingdotgg#30524); the fork's own versions are dropped (marker drops in definition.ts
  and referenceAutolinks.ts). pullRequestDetail.logic.ts's !N prompt line
  was deleted upstream (pingdotgg#31819).
- Source-control media keeps the fork's cwd beside upstream's repository.
- ChatView's composer block was taken from pingdotgg#28223's re-indentation with the
  fork's cuts reapplied; state/pullRequests.ts was taken from upstream with
  persistence and routing removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds the voice input cut and the secret-request, settings-secret, and
hydration-watcher parts of the secret-provider cut, records the new seams
(text-generation fallback without the usage trigger, media repository beside
cwd, GitLab upload resolution ahead of upstream's root-relative media URLs,
ACP thread id environment, titlebar height in the route modal and command
dialog, theme atoms on the active workspace, Kilo session project recovery),
drops the GitLab author and autolink seams upstream now covers, lists the cut
paths in sync-resolve-deleted, bumps SYNC_BASE, and notes the per-file revert
technique and an empty-file pitfall in sync.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… drop the voice keybinding paragraph

The PR-watch summary test expects the fork's !N wording, the fork-only Codex
thread-params test includes pingdotgg#31149's concurrent reasoning summaries key, and
keybindings.md no longer documents the cut dictation shortcut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…only seams

pingdotgg#32833 reworded the html_preview step in the orchestration instructions, so the
bridge rewrite matches the new sentence. Upstream's media-table tests use GitLab
uploads and the fork's hostLabel field, reference labels expect !N, the
pingdotgg#31642 folder-caret test picks the workspace first, and the fork-only autolink
fragment case is dropped now that upstream's GitLab grammar links qualified
references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er the voice cut

The voice revert dropped pingdotgg#30623's non-voice review shortcut and fresh
draft read along with the speech hooks. Take upstream's form minus the
speech code, and upstream's commentSubmitShortcut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.