Skip to content

docs: close the five review findings left on the A2ML exit (#383) - #384

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/a2ml-exit-review-followups
Nov 14, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/a2ml-exit-review-followups

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

#383 was squash-merged with five Codex P2 findings still open. All five were real on main (559004b), and this PR fixes them. It is a new branch cut from main, because this repo squash-merges.

Changes

  1. Bun policy, everywhere.
    • docs/AI-CONVENTIONS.adoc gets a new JavaScript Runtime section: Bun > Deno > pnpm > npm, both package.json and bun.lock required, no TypeScript.
    • .github/copilot-instructions.md says the same.
    • .github/pull_request_template.md no longer asks authors to certify "no Bun". It asks for Bun first.
  2. Where the tier-2 gateway status lives. The Trustfile contract was deleted, but the rollout runbook still named it as the target for its final attestation.
    • The status (PENDING) is now a "Tier-2 gateway status" item under v1.1.0 in docs/status/ROADMAP.adoc.
    • The runbook (§0, §1.2, §1.4, §5.3, §6, §6.4, Appendices A and B) points there.
    • The ledger records the move, and says the status goes to Trustfile.deed once that form exists.
    • No new deed form is invented.
  3. docs/wikis/Developer-Guide.adoc.
    • The TOML block presented as cartridge.json is replaced with JSON that validates against schemas/cartridge-v1.json.
    • The example name changes to database-pg-mcp, because the schema requires the role suffix last. The old name fails, which serves as the negative control.
    • A dead EXTENSIBILITY.md link now points at the .adoc file.
  4. .boj/project-memories.a2ml. The STATE.a2ml backend count update item is removed by deletion only; nothing is added. The ledger row is re-hashed.
  5. docs/history/A2ML-REMOVED.adoc. The root 0-AI-MANIFEST.a2ml row carried the values of the .machine_readable/6a2/ copy. Its real values at ad5bcdb are 5054 bytes, sha256 147b9d52…, blob e8f6c4b3…. All 52 rows were rechecked against ad5bcdb, and this was the only wrong one.

Verification

  • The example JSON is checked with ajv 8.17.1 (draft 2020-12, run under Bun): VALID, and the old name is INVALID.
  • asciidoctor.js reports 0 warnings on the 6 changed .adoc files.
  • just validate-rsr: PASS. just validate-state: valid.
  • validate-a2ml.sh: 0 errors. git diff --check: clean.
  • just validate fails only at validate-ai-install, and fails the same way on main.

Seen, not fixed (for the owner)

  • There is no bun.lock at the root, though package.json exists.
  • docs/EXTENSIBILITY.adoc §1 has the same TOML-as-JSON block, a backend field the schema doesn't have, and names that break the role-suffix rule.
  • Other references to the retired Trustfile remain (elixir/README.adoc, contractile.just, CODEOWNERS, gateway docs, the maintenance checklist).
  • Several integration docs link to .md files that are .adoc.

Generated by Claude Code

- Runtime policy: docs/AI-CONVENTIONS.adoc, .github/copilot-instructions.md
  and the PR template still banned Bun and required Deno. They now follow
  the estate order Bun > Deno > pnpm > npm (Deno tier 2, npm last resort),
  require package.json + bun.lock, and keep TypeScript banned.
- Tier-2 gateway status: the retired Trustfile was the runbook's flip
  target. The status now lives in a "Tier-2 gateway status" item in
  docs/status/ROADMAP.adoc; the HCG rollout runbook (§1.4, §5.3, §6.4,
  appendices) points there, and the ledger records the move. It moves to
  Trustfile.deed once that is written.
- Developer Guide: the extension descriptor was a TOML block presented as
  cartridge.json. It is now JSON that validates against
  schemas/cartridge-v1.json (role suffix last: database-pg-mcp).
- .boj/project-memories.a2ml: the "STATE.a2ml backend count update"
  item is deleted (deletion only); the ledger row is re-hashed.
- Ledger: the root 0-AI-MANIFEST.a2ml row carried the values of
  .machine_readable/6a2/0-AI-MANIFEST.a2ml. Corrected from ad5bcdb
  (5054 bytes, sha256 147b9d52..., blob e8f6c4b...). Every other row
  was re-checked against git history and matches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC
@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 67 issues detected

Severity Count
🔴 Critical 1
🟠 High 11
🟡 Medium 55

⚠️ Action Required: Critical security issues found!

View findings (sorted by severity)
[
  {
    "line": 70,
    "reason": "believe_me undermines formal verification (4 occurrences, CWE-704, line 70, 269, 279, 289)",
    "type": "believe_me",
    "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "critical",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/src/abi/Boj/SafetyLemmas.idr",
          "end_line": 70,
          "start_line": 70
        },
        "rule": "code_safety/believe_me",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Step uses `peter-evans/repository-dispatch` with `token: ${{ secrets.FARM_DISPATCH_TOKEN }}` but has no `if: secrets.FARM_DISPATCH_TOKEN != ''` gate. On repos where the secret hasn't been propagated the action fails on every push, red-maining the repo. Add the step-level gate (or env+if pattern) so the missing-secret path is a clean skip instead of a red.",
    "type": "secret_action_without_presence_gate",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "peter-evans/repository-dispatch",
    "severity": "high",
    "fix_recipe": "add_secret_presence_gate",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/secret_action_without_presence_gate",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 29,
    "reason": "job `deploy` in .github/workflows/pages-deploy.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build) in the same step",
    "type": "RE001",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 29,
          "start_line": 29
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/workflow_audit/secret_action_without_presence_gate -- Hypatia workflow_audit: secret_action_without_presence_gate -- 41 day(s) old [STALE]",
    "type": "CSA001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code scanning (Hypatia): hypatia/code_safety/believe_me -- Hypatia code_safety: believe_me -- 44 day(s) old [STALE]",
    "type": "CSA001",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/proofs.yml is 33 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/proofs.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/proofs.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/secret_action_without_presence_gate (high) at .github/workflows/instant-sync.yml is 41 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/workflow_audit/missing_timeout_minutes (medium) at .github/workflows/pages-deploy.yml is 41 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/zig_bit_cast (medium) at ffi/zig/src/cartridge_shim.zig is 44 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "ffi/zig/src/cartridge_shim.zig",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert hypatia/code_safety/believe_me (high) at src/abi/Boj/SafetyLemmas.idr is 44 days old (threshold: 7 days) -- overdue for remediation",
    "type": "CSA003",
    "file": "src/abi/Boj/SafetyLemmas.idr",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": "src/abi/Boj/SafetyLemmas.idr",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/push-email-notify.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Code-scanning alert PinnedDependenciesID (medium) at .github/workflows/dogfood-gate.yml is 54 days old (threshold: 30 days) -- overdue for remediation",
    "type": "CSA003",
    "file": ".github/workflows/dogfood-gate.yml",
    "level": "epi",
    "rule_module": "code_scanning_alerts",
    "action": "escalate",
    "severity": "high",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/dogfood-gate.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "code_scanning_alerts/CSA003",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "reason": "Job `deploy` in pages-deploy.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
    "type": "missing_timeout_minutes",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_audit",
    "action": "flag",
    "severity": "medium",
    "recipe_id": "recipe-add-workflow-timeout-minutes",
    "job": "deploy",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 0,
          "start_line": 0
        },
        "rule": "workflow_audit/missing_timeout_minutes",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 44,
    "reason": "job `build-and-push` in .github/workflows/container-publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/container-publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/container-publish.yml",
          "end_line": 44,
          "start_line": 44
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 37,
    "reason": "job `sonarqube` in .github/workflows/build.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/build.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/build.yml",
          "end_line": 37,
          "start_line": 37
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 88,
    "reason": "job `publish-bun` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 88,
          "start_line": 88
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 122,
    "reason": "job `publish-jsr` in .github/workflows/publish.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/publish.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/publish.yml",
          "end_line": 122,
          "start_line": 122
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 34,
    "reason": "job `dispatch` in .github/workflows/instant-sync.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/instant-sync.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/instant-sync.yml",
          "end_line": 34,
          "start_line": 34
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 278,
    "reason": "job `scan` in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring; it holds the credential next to fetched code (a piped installer or a dependency install/build)",
    "type": "RE001",
    "file": ".github/workflows/hypatia-scan.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/hypatia-scan.yml",
          "end_line": 278,
          "start_line": 278
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 46,
    "reason": "job `notify` in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` or declare its egress — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/push-email-notify.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/push-email-notify.yml",
          "end_line": 46,
          "start_line": 46
        },
        "rule": "research_extensions/RE001",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 38,
    "reason": "workflow .github/workflows/fuzz.yml:38 step `Run core FFI fuzz tests` swallows non-zero exit via `continue-on-error: true` AND `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/fuzz.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/fuzz.yml",
          "end_line": 38,
          "start_line": 38
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 224,
    "reason": "workflow .github/workflows/abi-drift.yml:224 step `Scope cartridges to verify` swallows non-zero exit via `|| true` — failures will be masked",
    "type": "RE005",
    "file": ".github/workflows/abi-drift.yml",
    "level": "epi",
    "rule_module": "research_extensions",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/abi-drift.yml",
          "end_line": 224,
          "start_line": 224
        },
        "rule": "research_extensions/RE005",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 22,
    "reason": "workflow .github/workflows/pages-deploy.yml:22 job `deploy` has no `timeout-minutes:` — defaults to 360 min on hang",
    "type": "WH006",
    "file": ".github/workflows/pages-deploy.yml",
    "level": "epi",
    "rule_module": "workflow_hardening",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": ".github/workflows/pages-deploy.yml",
          "end_line": 22,
          "start_line": 22
        },
        "rule": "workflow_hardening/WH006",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 175,
    "reason": "Zig @bitCast reinterprets bits without type checking (1 occurrences, CWE-704, line 175)",
    "type": "zig_bit_cast",
    "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
    "level": "epi",
    "rule_module": "code_safety",
    "action": "flag",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/ffi/zig/src/cartridge_shim.zig",
          "end_line": 175,
          "start_line": 175
        },
        "rule": "code_safety/zig_bit_cast",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  },
  {
    "line": 58,
    "reason": "Secret found: Generic API key (placeholder-shaped value — verify it is not a real credential)",
    "type": "secret_detected",
    "file": "/home/runner/work/boj-server/boj-server/tools/cartridge-provisioner/README.adoc",
    "level": "epi",
    "rule_module": "security_errors",
    "action": "report",
    "severity": "medium",
    "evidence": [
      {
        "span": {
          "file": "/home/runner/work/boj-server/boj-server/tools/cartridge-provisioner/README.adoc",
          "end_line": 58,
          "start_line": 58
        },
        "rule": "security_errors/secret_detected",
        "observations": 1,
        "rule_version": "0.1.0"
      }
    ],
    "support": {
      "kind": "pattern"
    }
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 14, 2026 20:51
@hyperpolymath
hyperpolymath merged commit a9ecf97 into main Nov 14, 2026
29 of 31 checks passed
@hyperpolymath
hyperpolymath deleted the fix/a2ml-exit-review-followups branch November 14, 2026 20:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:56:30.574046Z f044203 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T20:55:15.631122Z f044203 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0442035e8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/status/ROADMAP.adoc
* [x] Implement `PolicyLoader.load_from_boj_catalog/1` in `http-capability-gateway` — reads `BOJ_CARTRIDGES_ROOT/*/cartridge.json` at boot, infers per-cartridge invoke exposure from `auth.method` (`none` → `public`, others → `authenticated`). Zero manual policy maintenance thereafter. See `docs/gateway-catalog-integration.adoc`.
* [x] Update `compose.dev.yaml` with gateway sidecar entry (port 7800 → boj-rest:7700)
* [x] Retire static `gateway-policy.yaml` — catalog mode live 2026-04-25; file kept as reference only
* [ ] Tier-2 gateway status: `PENDING — http-capability-gateway wiring forthcoming`. Production rollout under `standards#100` per `docs/integration/hcg-tier2-rollout-runbook.adoc`, whose §6.4 flips this item to `DEPLOYED` (with `deployed_at` and the evidence links) as its last action, and whose §5.3 sets it to `DISABLED` on a permanent disable. This status was `[CLOUDFLARE_EDGE_SECURITY].rate_limiting.tier_2_gateway.status` in the Trustfile retired on 2026-11-14 (`docs/history/A2ML-REMOVED.adoc`); it moves to `Trustfile.deed` when that is written.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify when permanent disable changes the status

When a gateway version is permanently disabled before the final §6.4 flip—such as during the rollout or seven-day soak—§5.3 explicitly leaves this item at PENDING and only records the incident. Therefore the new claim that §5.3 sets it to DISABLED is false for that common failure path and can mislead readers of the canonical status record; either describe the condition here or make §5.3 always record permanent disables.

Useful? React with 👍 / 👎.

Comment on lines +245 to +246
]
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Mark the shared-library manifest as an FFI cartridge

When a developer installs this manifest and follows the next section to build a shared library, the missing top-level ffi entry makes BojRest.Router.dispatch/4 select JsWorkerPool and look for <cartridges_root>/database-pg-mcp/mod.js; the built library is never invoked. Add the ffi.so_path metadata and document the current cartridge ABI, or change the example to provide the JavaScript module that this manifest currently selects.

Useful? React with 👍 / 👎.

Comment thread docs/AI-CONVENTIONS.adoc
Comment on lines +104 to +106
Order: *Bun > Deno > pnpm > npm*. Bun is tier 1 and comes first everywhere;
Deno is permitted at tier 2; npm is the last resort (permitted, never
preferred), and `package-lock.json` is never tracked. JS dependencies are

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reconcile the runtime policy with the repository deed

At session startup this document requires agents to read boj-server_chora.deed, but that deed's implementation-policy allows JavaScript only as Deno and expressly forbids npm, while these new lines require Bun first and permit npm as a fallback. An agent following both mandatory sources therefore has no consistent policy for Bun/npm changes; synchronize the deed with this policy or retain the existing restrictions here until the canonical source is updated.

Useful? React with 👍 / 👎.

hyperpolymath added a commit that referenced this pull request Nov 14, 2026
…ns.lock (#385)

## Summary

`governance` is red on main, and it was red on #384 for the same reason.

Dependabot's #379 regenerated `.github/workflows/actions.lock` and
dropped the entries that #368 had added by hand for `release.yml`'s
job-level reusable workflow,
`slsa-framework/slsa-github-generator@f7dd8c54…` (v2.1.0). `gh
actions-lock` does not handle job-level reusable-workflow refs, so they
have to be added by hand. CI's `check-lock-sync` reports:

```
FAIL .github/workflows/release.yml
     refs missing from the lockfile: slsa-framework/slsa-github-generator@f7dd8c5
```

## Changes

The entries are restored byte for byte from #368's lock (282df49), as
additions only and in the lock's own key order:

- the `release.yml` workflow edge;
- the dependency records it closes over:
  - the generator, at its SHA and at `v2.1.0`;
  - its transitive `actions/upload-artifact@65c4c4a1…` (v4.6.0);
  - its transitive `softprops/action-gh-release@c95fe148…` (v2.2.1).

No workflow changes.

## Verification

Run with the standards tools at the commit `governance.yml` pins
(`1725beb`):

- **main:** `check-lock-sync.sh` fails with the error above.
- **this branch:** `check-workflows-parse.sh`, `check-lock-sync.sh`,
`close-lock.sh --check` and `check-workflow-duplicate-keys.sh` all pass.

## Note

Dependabot's lock rewrite will drop these entries again the next time it
touches `release.yml`'s neighbours. A lasting fix belongs in the lock
tooling, not here.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7ZoBy5xGnGDLk7wQ8jC)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants