Repository navigation
chore(deps): bump OpenShell crates to v0.1.8 - #96
Merged
Merged
Conversation
Closes #80 Pins openshell-policy-schema and openshell-policy to the stable OpenShell v0.1.8 tag and updates every version string, the generated policy headers and goldens. Handles the v0.1.8 upgrade notes that touch annotate (see PR description). Signed-off-by: Ilan Harel <ilanharel@gmail.com>
….8-80 Signed-off-by: Ilan Harel <ilanharel@gmail.com> # Conflicts: # CHANGELOG.md
ilanh
added a commit
that referenced
this pull request
Nov 16, 2026
…pped hosts (#97) Closes #95 Lint warnings for OpenShell v0.1.8 runtime changes that the policy validator does not catch (split out of #80 to keep the bump PR #96 reviewable; independent of it). ## Change - **WebSocket on `rest`** (NVIDIA/OpenShell#5336, REST endpoints answer upgrades with 403): `warning[net]` for a `ws://`/`wss://` URL literal whose host:port is declared only by an inspected `rest` egress (`protocol=rest`, or `access=`/`allow=` with no protocol). Not reported when any `protocol=websocket` (or other non-rest) egress also covers it, for L4 passthrough egress, on comment-only lines, in excluded files, or under a nearby `@openshell ignore kind=net`. Engine-independent (works with `engine = "regex"` too). - **IPv4-mapped hosts** (NVIDIA/OpenShell#5101, evaluated as IPv4): new `validate::host_warning` (any `::ffff:` form, bracketed or hex) → `warning[directive]` on egress directives, and a warning from `check_document`, so `lint --policy`, `drift` and `generate` report it in policy files. - **Symlinked fs paths** (NVIDIA/OpenShell#5278): not detectable statically (the symlink is in the image); README "Limits" says so and what to do. ## Docs README "Limits" bullet; CHANGELOG Unreleased. No CLI flags or directive syntax changed, so `docs/CLI.md`/`docs/DIRECTIVES.md` are unchanged (`gen-docs.sh --check` passes). ## Verified (Rust 1.94.1) `scripts/ci-local.sh` passes (fmt, clippy `-D warnings`, all tests, docs checks). New tests: `lint_warns_about_websocket_urls_on_rest_egress`, `lint_policy_warns_about_ipv4_mapped_hosts`, unit `ipv4_mapped_hosts_warn`. `examples/polyglot` still lints clean with `--deny-warnings`, so `actions-selftest` is unaffected. Not merging; needs Ilan's approval. Signed-off-by: Ilan Harel <ilanharel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Bumps
mainto the stable OpenShell v0.1.8 (released 2026-11-10, tag commitf3d97659).Change
Cargo.toml/Cargo.lock:openshell-policy-schemaandopenshell-policy→v0.1.8(viascripts/openshell-next.sh bump v0.1.8).src/generate.rs, goldenpolicy.expected.yaml,examples/polyglotpolicy), diff-logs/image notes (src/*.rs, threediff_logs_*goldens), README, AGENTS, ROADMAP, Dockerfile, DEVELOPING,.cargo/audit.tomlcomment. Real v0.1.7 log fixtures and theupstream-compat.shexamples keep their version on purpose.--scaffold-profilesskeletons explain the v0.1.8 credential placement rule (#4886); README "Credentials with no provider profile" too.egress protocol=help (→docs/DIRECTIVES.mdviagen-docs.sh): REST answers WebSocket upgrades with 403 since v0.1.8.openshell-nexthas already moved past the stable tag (what happened here).v0.1.8 upgrade notes, checked against the release notes and the v0.1.7→v0.1.8 source
websocket_credential_rewrite: trueneedsprotocol: websocket; REST → 403 on upgradeopenshell-policyl7_validate.rs) now rejects it, andlint --policy/drift/generaterun that validator. annotate never emits the key.websocket_credential_rewrite_needs_the_websocket_protocol; directive help. Lint warning for WebSocket URLs onrest→ #95 / PR #97container.*→device.container.*diff-logsreads no attribution fieldssandbox_attribution_location_does_not_matter(both shapes parse the same); DEVELOPING note. No parser change needed::ffff:a.b.c.devaluated as IPv4Authorizationunless placement declaredauth_style: bearer+header_name: authorization(explicit)header/query/pathplacementdeny_unknown_fieldsopenshell-policy-schemadiff is one doc comment; no new or removed keyssqlx0.9.0 /libsqlite3-sys0.37.0PROXY_BASELINE_*generate --imagebaseline unchangedopenshell-next / #82
openshell-nextis already onv0.1.9-pre.3. When the workflow merges this into it,synckeeps the newer pin (v0.1.9-pre.3) and the other files merge cleanly (the branch only differs inCargo.toml/Cargo.lock). After this merges #80 closes, and the workflow opens a newopenshell-nexttracking issue at the next upstream tag. #82 can then either be retitled to track v0.1.9 (it already carries v0.1.9-pre.3) or be closed and replaced by a fresh draft; its body/checklist is v0.1.8-specific, so I'd retitle and refresh it.Verified (Rust 1.94.1, Linux)
scripts/ci-local.sh: fmt, clippy-D warnings,cargo test --locked(all suites, incl.gateway_policies),gen-docs.sh --check,gen-actions-docs.sh --checkall pass.Not tested: a real v0.1.8 gateway/sandbox run of the playground flow (#80 checklist item); the iMac/nemoclaw was offline.
Not merging; needs Ilan's approval.