Skip to content

feat(lint): warn about OpenShell v0.1.8 WebSocket-on-rest and IPv4-mapped hosts - #97

Merged
ilanh merged 2 commits into
mainfrom
cursor/lint-v0.1.8-pitfalls
Nov 16, 2026
Merged

ilanh merged 2 commits into
mainfrom
cursor/lint-v0.1.8-pitfalls

Conversation

@ilanh

@ilanh ilanh commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Closes #95

Lint warnings for OpenShell v0.1.8 runtime changes that the policy validator does not catch (split out of #80 to keep the bump PR #96 reviewable; independent of it).

Change

Docs

README "Limits" bullet; CHANGELOG Unreleased. No CLI flags or directive syntax changed, so docs/CLI.md/docs/DIRECTIVES.md are unchanged (gen-docs.sh --check passes).

Verified (Rust 1.94.1)

scripts/ci-local.sh passes (fmt, clippy -D warnings, all tests, docs checks). New tests: lint_warns_about_websocket_urls_on_rest_egress, lint_policy_warns_about_ipv4_mapped_hosts, unit ipv4_mapped_hosts_warn. examples/polyglot still lints clean with --deny-warnings, so actions-selftest is unaffected.

Not merging; needs Ilan's approval.

…pped hosts

Closes #95

- ws:// / wss:// URL literals whose host is declared only by an inspected
  rest egress directive: REST endpoints answer WebSocket upgrades with 403
  since OpenShell v0.1.8 (NVIDIA/OpenShell#5336).
- IPv4-mapped IPv6 hosts (::ffff:a.b.c.d) in egress directives and policy
  files: evaluated as IPv4 since v0.1.8 (NVIDIA/OpenShell#5101).
- README: symlinked filesystem paths fail launch since v0.1.8
  (NVIDIA/OpenShell#5278) and cannot be detected statically.

Signed-off-by: Ilan Harel <ilanharel@gmail.com>
ilanh added a commit that referenced this pull request Nov 16, 2026
Closes #80

Bumps `main` to the stable [OpenShell
v0.1.8](https://github.com/NVIDIA/OpenShell/releases/tag/v0.1.8)
(released 2026-11-10, tag commit `f3d97659`).

## Change
- `Cargo.toml`/`Cargo.lock`: `openshell-policy-schema` and
`openshell-policy` → `v0.1.8` (via `scripts/openshell-next.sh bump
v0.1.8`).
- Version strings → v0.1.8: generated policy header (`src/generate.rs`,
golden `policy.expected.yaml`, `examples/polyglot` policy),
diff-logs/image notes (`src/*.rs`, three `diff_logs_*` goldens), README,
AGENTS, ROADMAP, Dockerfile, DEVELOPING, `.cargo/audit.toml` comment.
Real v0.1.7 log fixtures and the `upstream-compat.sh` examples keep
their version on purpose.
- `--scaffold-profiles` skeletons explain the v0.1.8 credential
placement rule (#4886); README "Credentials with no provider profile"
too.
- `egress protocol=` help (→ `docs/DIRECTIVES.md` via `gen-docs.sh`):
REST answers WebSocket upgrades with 403 since v0.1.8.
- RELEASING: how to promote when `openshell-next` has already moved past
the stable tag (what happened here).

## v0.1.8 upgrade notes, checked against the release notes and the
v0.1.7→v0.1.8 source
| Upstream change | Effect on annotate | Done here |
|---|---|---|
| #5336 `websocket_credential_rewrite: true` needs `protocol:
websocket`; REST → 403 on upgrade | The gateway validator
(`openshell-policy` `l7_validate.rs`) now rejects it, and `lint
--policy`/`drift`/`generate` run that validator. annotate never emits
the key. | Test
`websocket_credential_rewrite_needs_the_websocket_protocol`; directive
help. Lint warning for WebSocket URLs on `rest` → #95 / PR #97 |
| #5048 OCSF `container.*` → `device.container.*` | `diff-logs` reads no
attribution fields | Unit test
`sandbox_attribution_location_does_not_matter` (both shapes parse the
same); DEVELOPING note. No parser change needed |
| #5278 symlinked fs paths fail launch | Runtime (Landlock) only; not
detectable statically | Documented in PR #97 |
| #5101 `::ffff:a.b.c.d` evaluated as IPv4 | Runtime only, validator
unchanged | Lint warning → #95 / PR #97 |
| #4886 static credentials only in `Authorization` unless placement
declared | Skeletons already emit `auth_style: bearer` + `header_name:
authorization` (explicit) | Skeleton comment + README explain
`header`/`query`/`path` placement |
| Schema / `deny_unknown_fields` | `openshell-policy-schema` diff is one
doc comment; no new or removed keys | — |
| RUSTSEC-2026-0459 | v0.1.8 still pins `sqlx` 0.9.0 / `libsqlite3-sys`
0.37.0 | Ignore stays; comment updated |
| `PROXY_BASELINE_*` | Unchanged in v0.1.8 | `generate --image` baseline
unchanged |
| #4270 FS denial logging | Still open upstream | Notes now say "not
logged by OpenShell 0.1.8" |

## openshell-next / #82
`openshell-next` is already on `v0.1.9-pre.3`. When the workflow merges
this into it, `sync` keeps the newer pin (v0.1.9-pre.3) and the other
files merge cleanly (the branch only differs in
`Cargo.toml`/`Cargo.lock`). After this merges #80 closes, and the
workflow opens a new `openshell-next` tracking issue at the next
upstream tag. **#82** can then either be retitled to track v0.1.9 (it
already carries v0.1.9-pre.3) or be closed and replaced by a fresh
draft; its body/checklist is v0.1.8-specific, so I'd retitle and refresh
it.

## Verified (Rust 1.94.1, Linux)
`scripts/ci-local.sh`: fmt, clippy `-D warnings`, `cargo test --locked`
(all suites, incl. `gateway_policies`), `gen-docs.sh --check`,
`gen-actions-docs.sh --check` all pass.

Not tested: a real v0.1.8 gateway/sandbox run of the playground flow
(#80 checklist item); the iMac/nemoclaw was offline.

Not merging; needs Ilan's approval.

Signed-off-by: Ilan Harel <ilanharel@gmail.com>
…tfalls

Signed-off-by: Ilan Harel <ilanharel@gmail.com>

# Conflicts:
#	CHANGELOG.md
@ilanh
ilanh merged commit fb9a5f8 into main Nov 16, 2026
17 checks passed
@ilanh
ilanh deleted the cursor/lint-v0.1.8-pitfalls branch November 16, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lint: warn about OpenShell v0.1.8 pitfalls (WebSocket on rest, IPv4-mapped hosts, symlinked fs paths)

1 participant