Repository navigation
docs: file the test packages that can still reach the machine's gh login - #1244
Merged
Merged
Conversation
The guard #1147 adds covers the four test packages on the announce path. Twenty-one more depend on internal/core/github without it; this records them so the follow-up is not left in a pull-request body. Refs: iss-2610291946475029 Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files the follow-up #1147 listed in its body as its own record, so it isn't lost there.
#1147 gave the four test packages on the landing announce path a TestMain that hides the machine's gh login: an empty gh configuration directory, and the gh token variables unset. Twenty-one other test packages depend on internal/core/github without that guard. A test in any of them that reaches the forge reads the developer's real login, so it can pass locally and fail on CI, which has none. The new record's remedy is to give those packages the same guard, and to add a check that names any package depending on internal/core/github without one.
Records only, with no code change.
Commits:
Refs: iss-2610291946475029
Assisted-by: Claude:claude-opus-5-5