Skip to content

Repository navigation

docs: file the test packages that can still reach the machine's gh login #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
REPPL merged 2 commits into from
Oct 30, 2026
Merged

docs: file the test packages that can still reach the machine's gh login #1244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9cd8fe
docs: file the test packages that can still reach the machine's gh login
REPPL Oct 29, 2026
41aa207
chore: merge origin/main into the gh-login capture branch
REPPL Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...rk/issues/open/iss-2610291946475029-test-packages-reach-the-machine-gh-login.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
schema_version: 1
id: "iss-2610291946475029"
slug: "test-packages-reach-the-machine-gh-login"
severity: "minor"
category: "tech-debt"
source: "review-followup"
found_during: "#1147 merge-queue failure follow-up, 2026-10-29"
origin: researcher-authored
production_mode: hand-written
found_at: "internal/core/github"
remedy: "Give each of these packages the same TestMain guard #1147 adds to the landing, claim, implement loop and CLI test packages (HideGHLogin in internal/gittest: an empty GH_CONFIG_DIR and the gh token variables unset), and add a check that names any test package depending on internal/core/github without it."
---

Twenty-one test packages depend on internal/core/github but have no TestMain hiding the machine's gh login: afterupdate, ahoy, autonomy, capture, embargo, github, ideate, implement, lifeboat, reading, record, release, repolint, report, reservesweep, scribe, site, sweep, update, surface/session and surface/session/web. A test in any of them that reaches the forge reads the developer's real login and tokens, so it can pass locally and fail on CI, which has no login, as the landing body test did in the merge queue for #1147.
Loading