Repository navigation
Fix release workflow: build router binary, check out repo for reranker publish - #25
Merged
Merged
Conversation
Possible relctl commands for this Pull RequestVersion scheme: calver. The version of the release is the date of the release ( Need more help? Have a look at my repo This message was created by relctl and can be disabled by the env variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The first run of the component-based Release workflow (run 20, commit e1d179d) failed in two jobs. Both are workflow wiring problems, not relctl bugs.
router-build:deploy/Containerfile.routerdoesCOPY /build/bin/inference-router, but the job never built the binary. The old workflow had amake build/routerstep before the image build; it was lost in the rewrite. Error:"/build/bin/inference-router": not found.reranker-model-publish: this standalone job runsrelctl release publishwithoutactions/checkout, so relctl finds no.relctl.yamland fails withunknown component "reranker-model": the config file defines no components. All other publish steps run inside build jobs that already check out the repository.The chart jobs were skipped as a consequence of the router failure.
Fix
router-build: add aBuild router binarystep (make build/router) before the image build.reranker-model-publish: addactions/checkout@v7before the publish step.yamllintreports only line-length warnings (pre-existing style).State left by run 20
tei/202611.3.1:202611.3.1embedding-model/202611.3.1bge-m3-202611.3.1whisper/202611.3.1How to re-run
router/202611.3.1andreranker-model/202611.3.1(they have no git tags yet). Keep the three published releases and their tags.components=router,reranker-model. Do not useall: tei, embedding-model and whisper are already released.202611.3.2for the new drafts.