Repository navigation
feat(torrent): block peers by address - #675
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6f48df28e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c6f48df to
626eee5
Compare
626eee5 to
59cc713
Compare
b76ad54 to
2a17588
Compare
6595921 to
eebc386
Compare
eebc386 to
3957849
Compare
Stacked on the seed queue PR; only the last two commits belong to this PR.
What
The IP filter part of the "Network control" row of #162.
TorrentConfig.blockedAddresses,[torrent] blocklistandTorrentEngineSettings.blockedAddresses(live throughsetBlockedAddressesandPUT /api/torrents/settings) take single addresses, CIDR blocks and ranges, IPv4 or IPv6, up to 10,000. Devices list theip-filtercapability.Snapshots
New settings group, so there is no before.
Testing
TorrentIpFilterTest(addresses, blocks, ranges, mapped addresses, bounds, refusals),TorrentBlockedPeersTestagainst a real engine and a loopback seeder (never dialed while blocked, completes once unblocked),BlockedAddressesTestfor the app's parsing. The full suites are running on this branch as this is opened.Not built here: proxies and interface binding for torrents, the rest of that roadmap row.