Repository navigation
feat(torrent): add and remove a torrent's trackers - #677
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9337277890
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
4d6384c to
dd9191f
Compare
9337277 to
b8ec0a0
Compare
eebc386 to
3957849
Compare
b8ec0a0 to
fa4be47
Compare
fa4be47 to
239e581
Compare
… edits before metadata
Stacked on #675.
What
TorrentController.editTrackers(taskId, TorrentTrackerEdit(add, remove)), capabilitytracker-edit, RESTPUT /api/torrents/{id}/trackers(answers the new list) and the remote client.http,httpsorudp, or more than 128 trackers, isinvalid_input, and the refusal never repeats the URL.TorrentSourceState.trackerTiers) and replaces the torrent's own trackers whenever a session of it opens, v1, v2 and hybrid. A downloading task is paused and resumed and a seeding one stopped and seeded again, so the change applies at once.Limits
.torrentor magnet link still names the trackers the task was added with.Snapshots
Tests
TorrentSeedingControlTest(a seeding task announces to its new tracker and saves the list),TorrentTrackerViewsTest,KetchTorrentControllerTest,TrackersTabTest, and the full torrent, core, server, remote and app JVM suites locally.