Skip to content

feat(torrent): add and remove a torrent's trackers - #677

Merged
linroid merged 2 commits into
mainfrom
feat/torrent-edit-trackers
Nov 14, 2026
Merged

linroid merged 2 commits into
mainfrom
feat/torrent-edit-trackers

Conversation

@linroid

@linroid linroid commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Stacked on #675.

What

  • TorrentController.editTrackers(taskId, TorrentTrackerEdit(add, remove)), capability tracker-edit, REST PUT /api/torrents/{id}/trackers (answers the new list) and the remote client.
  • Added announce URLs go after the torrent's own trackers, each as a tier of its own; removal is by endpoint (scheme, host and port), so no path or passkey is ever sent back. A URL that is not http, https or udp, or more than 128 trackers, is invalid_input, and the refusal never repeats the URL.
  • The edited list is saved with the task (TorrentSourceState.trackerTiers) and replaces the torrent's own trackers whenever a session of it opens, v1, v2 and hybrid. A downloading task is paused and resumed and a seeding one stopped and seeded again, so the change applies at once.
  • Inspector → Trackers: a remove button per tracker and an Add trackers field, on devices listing the capability; strings in all ten languages.
  • Fix: a seeder that stopped saved its state from a copy taken when it started, over a download order or file priority changed meanwhile. Those settings and the trackers now update that copy too.

Limits

  • A task that never ran has no saved state yet and keeps the edit for the process only.
  • An exported .torrent or magnet link still names the trackers the task was added with.

Snapshots

Light Dark

Tests

TorrentSeedingControlTest (a seeding task announces to its new tracker and saves the list), TorrentTrackerViewsTest, KetchTorrentControllerTest, TrackersTabTest, and the full torrent, core, server, remote and app JVM suites locally.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T09:33:54.599170Z 9337277 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9337277890

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@claude

claude Bot commented Nov 14, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@linroid
linroid force-pushed the feat/torrent-ip-filter branch from 4d6384c to dd9191f Compare November 14, 2026 11:49
@linroid
linroid force-pushed the feat/torrent-edit-trackers branch from 9337277 to b8ec0a0 Compare November 14, 2026 11:50
@linroid
linroid force-pushed the feat/torrent-ip-filter branch 3 times, most recently from eebc386 to 3957849 Compare November 14, 2026 13:12
@linroid
linroid force-pushed the feat/torrent-edit-trackers branch from b8ec0a0 to fa4be47 Compare November 14, 2026 13:12
Base automatically changed from feat/torrent-ip-filter to main November 14, 2026 13:47
@linroid
linroid force-pushed the feat/torrent-edit-trackers branch from fa4be47 to 239e581 Compare November 14, 2026 13:48
@linroid
linroid merged commit 23c8cac into main Nov 14, 2026
@linroid
linroid deleted the feat/torrent-edit-trackers branch November 14, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant