Repository navigation
feat(torrent): move a torrent's files to another folder - #678
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce50c21317
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
linroid
force-pushed
the
feat/torrent-edit-trackers
branch
from
November 14, 2026 11:50
9337277 to
b8ec0a0
Compare
linroid
force-pushed
the
feat/torrent-relocate
branch
from
November 14, 2026 11:50
2d66986 to
c29faee
Compare
linroid
force-pushed
the
feat/torrent-edit-trackers
branch
from
November 14, 2026 13:12
b8ec0a0 to
fa4be47
Compare
linroid
force-pushed
the
feat/torrent-relocate
branch
from
November 14, 2026 13:12
c29faee to
6289321
Compare
linroid
force-pushed
the
feat/torrent-edit-trackers
branch
from
November 14, 2026 13:48
fa4be47 to
239e581
Compare
linroid
force-pushed
the
feat/torrent-relocate
branch
from
November 14, 2026 13:48
6289321 to
c816270
Compare
linroid
force-pushed
the
feat/torrent-relocate
branch
from
November 14, 2026 13:51
c816270 to
aa9fd47
Compare
…n and finish a copied move
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #677.
What
TorrentController.relocate(taskId, directory), capabilityrelocate, RESTPUT /api/torrents/{id}/location(answers the snapshot) and the remote client. The files keep their name inside the new folder.SourceHost.relocate(core) runs under the task's control lock with no execution active. It refuses a relative folder, the folder the task is in, a folder inside its files, a name that is taken and another unfinished task's output, and saves the new output path and source state in one record write.TorrentPieceStore(adoptExisting)), as v2 stores already could, so removing a moved task with its files deletes them. This also applies to a v1 task added to use files already on disk.DestinationGuard.checkMove, 403path_rejected).Limits
Tests
TorrentSeedingControlTest(a completed v1 task, a completed v2 task and a running download are moved, checked and owned at the new place; refusals),TorrentMoveTest(rename, copy between volumes, a failed copy, a taken name),TorrentRoutesTest(the route and its folder check). The torrent, core, server and remote JVM suites and the iOS compiles pass locally; the first full run ended in a build failure I could not attribute to a test or a compile error, and passed when run again.