Skip to content

feat(app): move a torrent's files from its row menu - #679

Merged
linroid merged 1 commit into
mainfrom
feat/torrent-move-ui
Nov 14, 2026
Merged

linroid merged 1 commit into
mainfrom
feat/torrent-move-ui

Conversation

@linroid

@linroid linroid commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Stacked on #678.

What

  • A finished torrent's row menu offers Move files…: it opens the system folder dialog, starting where the torrent is saved, and moves the files into the chosen folder through TorrentController.relocate. A failure shows the usual one toast naming the task and device.
  • Offered only for torrents on this device where the folder dialog answers a file path (FilePicker.picksFilePaths): the desktop app, not Android's document trees or the web.
  • Strings in all ten languages.

Limits

  • No control for torrents on remote devices, which would need a typed path.
  • Not offered on Android, whose folder dialog names document trees that torrents cannot be saved to.
  • A move between volumes shows no progress while the files are copied.

Snapshots

Light Dark

Tests

RowContentTest (offered for torrents on this device only), the app's JVM suite including HardcodedTextTest, LocalizationResourcesTest and DesignTokenUsageTest, and the iOS compile, locally. The move itself is not exercised from the UI by a test: the folder dialog is a system one.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T10:13:57.241763Z cd7fed9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Nov 14, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@linroid
linroid force-pushed the feat/torrent-relocate branch from 2d66986 to c29faee Compare November 14, 2026 11:50
@linroid
linroid force-pushed the feat/torrent-move-ui branch from cd7fed9 to 09db716 Compare November 14, 2026 11:50
@linroid
linroid force-pushed the feat/torrent-relocate branch from c29faee to 6289321 Compare November 14, 2026 13:12
@linroid
linroid force-pushed the feat/torrent-move-ui branch from 09db716 to fa00f8b Compare November 14, 2026 13:12
@linroid
linroid force-pushed the feat/torrent-relocate branch from 6289321 to c816270 Compare November 14, 2026 13:48
@linroid
linroid force-pushed the feat/torrent-move-ui branch from fa00f8b to 8dbb866 Compare November 14, 2026 13:48
@linroid
linroid force-pushed the feat/torrent-relocate branch from c816270 to aa9fd47 Compare November 14, 2026 13:51
@linroid
linroid force-pushed the feat/torrent-move-ui branch from 8dbb866 to 79a019b Compare November 14, 2026 13:51
Base automatically changed from feat/torrent-relocate to main November 14, 2026 14:29
@linroid
linroid force-pushed the feat/torrent-move-ui branch from 79a019b to 4f860fd Compare November 14, 2026 14:30
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

 2 320 files   2 348 suites   59m 30s ⏱️
16 359 tests 16 072 ✅ 287 💤 0 ❌
19 940 runs  19 653 ✅ 287 💤 0 ❌

Results for commit 4f860fd.

@linroid
linroid merged commit 976cd43 into main Nov 14, 2026
14 checks passed
@linroid
linroid deleted the feat/torrent-move-ui branch November 14, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant