Repository navigation
feat(mygo): expose desktop host input, geometry and theme APIs - #276
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
devin-ai-integration
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose production embedding APIs needed by the native desktop host, with one coherent pinned MyGo revision:
Backend.InputNoderesolves committed input ancestry and rejects remounted node incarnations.Backend.TextGeometry/CommittedBoundsexpose committed, expiring retained text geometry without re-shaping or a second editable document.Backend.SetThemeDefaults/ResolveColorinstall per-window authored palettes with subtree scoping;ComputeThemeVariables/ResolveThemeValuehandle nested variables and invalid cycles.Includes the input and text-geometry branches and pins the combined MyGo runtime. Lifetimes, migration examples and compatibility rules are recorded in
docs/api-migrations.md.Validated locally:
go test ./...,go test -race ./...,go vet ./...,go build ./...inplatform/mygo, using the downloaded pinned dependency, without a workspace override. No UI-driven testing.Link to Devin session: https://app.devin.ai/sessions/4a14d15bc6d44d18a9254cd088d5cc5e
Open in Devin Desktop: https://app.devin.ai/desktop/session/4a14d15bc6d44d18a9254cd088d5cc5e?variant=devin
Requested by: @tiensonqin