Repository navigation
chore: bump com.android.application from 8.11.1 to 9.5.0 in /example/android - #153
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps com.android.application from 8.11.1 to 9.5.0. --- updated-dependencies: - dependency-name: com.android.application dependency-version: 9.5.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
| plugins { | ||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | ||
| id "com.android.application" version "8.11.1" apply false | ||
| id "com.android.application" version "9.5.0" apply false |
There was a problem hiding this comment.
🔴 After this merges, the example Android app no longer builds, so the build-android CI job fails. AGP 9.x needs Gradle 9.1.0 or newer. The wrapper still pins gradle-8.14.3 in example/android/gradle/wrapper/gradle-wrapper.properties, and AGP stops configuration with a "Minimum supported Gradle version" error. Fix: in this same change, update distributionUrl to a Gradle 9.x release that AGP 9.5.0 supports. If you are not doing the AGP 9 migration now, keep AGP at 8.x and ignore this major version.
Why this was flagged
Any flutter build apk or Gradle sync of example/android runs .github/workflows/build-android.yml, and so do pull-request.yml and release-publish.yml. Both resolve com.android.application 9.5.0 from settings.gradle:22. Each AGP release checks the running Gradle version at plugin apply time. AGP 9.0 already requires at least Gradle 9.1.0, and the wrapper still points at gradle-8.14.3-all.zip, so configuration aborts before any task runs. On the base, AGP 8.11.1 supports Gradle 8.14.3 and the example builds. Nothing in the diff updates the wrapper, and Dependabot's gradle ecosystem only edits the plugin version string.
Verification: The diff changes settings.gradle:22 to id "com.android.application" version "9.5.0" apply false. The wrapper was not touched: example/android/gradle/wrapper/gradle-wrapper.properties still uses gradle-8.14.3-all.zip. AGP 9.0 already needs at least Gradle 9.1.0. On the base, AGP 8.11.1 with Gradle 8.14.3 is a supported pair, so this is a regression.
| plugins { | ||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | ||
| id "com.android.application" version "8.11.1" apply false | ||
| id "com.android.application" version "9.5.0" apply false |
There was a problem hiding this comment.
🔴 With AGP 9, the example app's Kotlin setup fails to build even after the Gradle wrapper is upgraded. AGP 9 enables built-in Kotlin by default and rejects the separate org.jetbrains.kotlin.android plugin, which settings.gradle:23 and app/build.gradle still apply. The android { kotlinOptions { ... } } block in app/build.gradle is also no longer supported. Fix: migrate to built-in Kotlin by removing the kotlin.android plugin and moving jvmTarget to kotlin { compilerOptions { ... } }. Or set android.builtInKotlin=false in gradle.properties. Either way, the Flutter-applied plugin modules must keep compiling.
Why this was flagged
settings.gradle:22 bumps com.android.application to 9.5.0 while settings.gradle:23 keeps org.jetbrains.kotlin.android 2.2.20. app/build.gradle still applies that plugin and uses kotlinOptions { jvmTarget = JavaVersion.VERSION_17 } inside android {}. In AGP 9, built-in Kotlin support is on by default. Applying the separate Kotlin Android plugin then fails with an error telling you to remove it or opt out with android.builtInKotlin=false. The kotlinOptions extension on android is also removed. example/android/gradle.properties sets neither android.builtInKotlin nor android.newDsl, so nothing opts out. On the base, AGP 8.11.1 with the separate Kotlin plugin builds fine. This needs a different fix from the Gradle wrapper issue (a build-script DSL migration, not a wrapper bump), so the build still fails after the wrapper is upgraded.
Verification: The diff changes settings.gradle:22 to id "com.android.application" version "9.5.0" apply false but leaves line 23 as id "org.jetbrains.kotlin.android" version "2.2.20" apply false. example/android/gradle.properties has no android.builtInKotlin=false opt-out. From AGP 9.0 onward, built-in Kotlin is on by default. On the base (AGP 8.11.1) the same files build.
|
Superseded by #156. |
Bumps com.android.application from 8.11.1 to 9.5.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)