Repository navigation
chore: bump com.android.application from 8.11.1 to 9.5.0 in /example/android #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ pluginManagement { | |
|
|
||
| plugins { | ||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | ||
| id "com.android.application" version "8.11.1" apply false | ||
| id "com.android.application" version "9.5.0" apply false | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 With AGP 9, the example app's Kotlin setup fails to build even after the Gradle wrapper is upgraded. AGP 9 enables built-in Kotlin by default and rejects the separate Why this was flaggedsettings.gradle:22 bumps Verification: The diff changes settings.gradle:22 to |
||
| id "org.jetbrains.kotlin.android" version "2.2.20" apply false | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 After this merges, the example Android app no longer builds, so the build-android CI job fails. AGP 9.x needs Gradle 9.1.0 or newer. The wrapper still pins gradle-8.14.3 in example/android/gradle/wrapper/gradle-wrapper.properties, and AGP stops configuration with a "Minimum supported Gradle version" error. Fix: in this same change, update distributionUrl to a Gradle 9.x release that AGP 9.5.0 supports. If you are not doing the AGP 9 migration now, keep AGP at 8.x and ignore this major version.
Why this was flagged
Any
flutter build apkor Gradle sync of example/android runs .github/workflows/build-android.yml, and so do pull-request.yml and release-publish.yml. Both resolvecom.android.application9.5.0 from settings.gradle:22. Each AGP release checks the running Gradle version at plugin apply time. AGP 9.0 already requires at least Gradle 9.1.0, and the wrapper still points at gradle-8.14.3-all.zip, so configuration aborts before any task runs. On the base, AGP 8.11.1 supports Gradle 8.14.3 and the example builds. Nothing in the diff updates the wrapper, and Dependabot's gradle ecosystem only edits the plugin version string.Verification: The diff changes settings.gradle:22 to
id "com.android.application" version "9.5.0" apply false. The wrapper was not touched: example/android/gradle/wrapper/gradle-wrapper.properties still uses gradle-8.14.3-all.zip. AGP 9.0 already needs at least Gradle 9.1.0. On the base, AGP 8.11.1 with Gradle 8.14.3 is a supported pair, so this is a regression.