Repository navigation
P0 Linux release: latest-stable guarded dispatch and packaged firmware smoke - #312
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 171d70e753
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| available=linux in assets | ||
| with open(os.environ['GITHUB_OUTPUT'],'a') as out: | ||
| out.write(f"dispatch={'false' if available else 'true'}\n") | ||
| out.write(f"dispatch={'false' if available else 'true'}\\n") |
There was a problem hiding this comment.
For an eligible release without Linux assets, the Python script writes the literal characters \n rather than a newline because the string contains \\n. Running the extracted eligibility script confirms that the output file contains 'dispatch=true\\n', so steps.eligibility.outputs.dispatch == 'true' on line 72 is false and the packaging workflow is never dispatched. Use a single Python newline escape in both output-writing branches.
Useful? React with 👍 / 👎.
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| TAG: ${{ github.event.release.tag_name }} | ||
| TAG: ${{ github.event_name == 'release' && github.event.release.tag_name || inputs.release_tag }} |
There was a problem hiding this comment.
For the newly supported workflow_dispatch path, this expression supplies the requested tag only to the eligibility step; the dispatch step still sets TAG exclusively from github.event.release.tag_name on line 75, which is absent for manual runs. After correcting the output newline, manual dispatch therefore sends release_tag= instead of the validated tag. The inspected gh workflow run --help defines --field key=value as “Add a string parameter in key=value format”; the receiving AppImage workflow treats a blank tag as artifact-only and skips release attachment. Apply the same event/input selection to the dispatch step.
Useful? React with 👍 / 👎.
Release P0 — Linux publishing reliability
Problem: Linux AppImage CI already builds and tests successfully, but the historical M3.H release was published before automatic Linux distribution existed. GitHub Actions release events can also be suppressed when a release is created using
GITHUB_TOKEN.Changes:
workflow_dispatchwith the exact stable tag as a fallback.Acceptance: PR CI validates workflow; when the next stable release publishes, GitHub releases event dispatches the exact-tag build. For a token-created release suppressing the published event, maintainers can use Actions → Attach Linux AppImage On Stable Release → Run workflow, supplying the newly published latest tag. The separate Linux build/attach job must pass before Linux becomes a public downloadable asset.
No release/tag creation or published asset mutation in this PR.