Repository navigation
P0 Linux release: latest-stable guarded dispatch and packaged firmware smoke #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
07f0b3a
ci(linux): exact-tag stable release guard, manual fallback and bundle…
masarray 171d70e
ci(linux): exact-tag stable release guard, manual fallback and bundle…
masarray 9a13890
fix(ci): correct GitHub Actions output newline and manual tag dispatch
masarray 41c13f0
ci(linux): require tagged release source in main ancestry before buil…
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the newly supported
workflow_dispatchpath, this expression supplies the requested tag only to the eligibility step; the dispatch step still setsTAGexclusively fromgithub.event.release.tag_nameon line 75, which is absent for manual runs. After correcting the output newline, manual dispatch therefore sendsrelease_tag=instead of the validated tag. The inspectedgh workflow run --helpdefines--field key=valueas “Add a string parameter in key=value format”; the receiving AppImage workflow treats a blank tag as artifact-only and skips release attachment. Apply the same event/input selection to the dispatch step.Useful? React with 👍 / 👎.