fix: extract card alertID from url for update endpoint - #387
Merged
Conversation
tessstoddard
requested review from
SandhyaBhatia,
gerfboy,
mattnichols,
meotch and
stevecl5
as code owners
August 25, 2026 20:52
tylerGroesbeckMx
previously approved these changes
Aug 25, 2026
stevecl5
reviewed
Aug 25, 2026
tessstoddard
force-pushed
the
tess/managed-card-alert-fix
branch
from
August 25, 2026 23:52
0fdd5ae to
d9d977d
Compare
stevecl5
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Extracting the alertId from the url for update managed card alert. Synchronicity does not pass on the alertId in the request body because it is already returned in the URL. So we need to update here to be able to retrieve that ID
Fixes # https://mxcom.atlassian.net/browse/GCU-1459
Public API Additions/Changes
Updates the ManagedCardAlertBaseAccessor update(cardId, alert) -> update(alertId, cardId, alert)
Downstream Consumer Impact
This only impacts path-connector-globalcu. It is the only service using this feature right now, which is still in development
How Has This Been Tested?
I created a local snapshot and verified that all the parameters were getting set correctly
Checklist: