Skip to content

fix: extract card alertID from url for update endpoint #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tessstoddard merged 1 commit into from
Aug 26, 2026
Merged

fix: extract card alertID from url for update endpoint #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions mdx-gateway-generator/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ com.fasterxml.jackson:jackson-bom:2.22.0=runtimeClasspath,testRuntimeClasspath
com.fasterxml.woodstox:woodstox-core:7.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.rholder:guava-retrying:2.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.spotbugs:spotbugs-annotations:4.10.2=annotationProcessor,testAnnotationProcessor
com.github.spotbugs:spotbugs-annotations:4.10.3=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.3=spotbugs
com.github.spotbugs:spotbugs-annotations:4.10.4=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.4=spotbugs
com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs
com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,compileClasspath,runtimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
com.google.code.gson:gson:2.14.0=compileClasspath,runtimeClasspath,spotbugs,testCompileClasspath,testRuntimeClasspath
Expand Down Expand Up @@ -78,7 +78,6 @@ org.junit.platform:junit-platform-engine:1.14.1=testCompileClasspath,testRuntime
org.junit.platform:junit-platform-launcher:1.14.1=testRuntimeClasspath
org.junit:junit-bom:5.14.1=testCompileClasspath,testRuntimeClasspath
org.junit:junit-bom:6.1.0=annotationProcessor,testAnnotationProcessor
org.junit:junit-bom:6.1.2=spotbugs
org.mockito:mockito-core:5.23.0=testCompileClasspath,testRuntimeClasspath
org.objenesis:objenesis:3.3=runtimeClasspath,testRuntimeClasspath
org.opentest4j:opentest4j:1.3.0=testCompileClasspath,testRuntimeClasspath
Expand All @@ -100,8 +99,8 @@ org.spockframework:spock-bom:2.4-groovy-4.0=testCompileClasspath,testRuntimeClas
org.spockframework:spock-core:2.4-groovy-4.0=testCompileClasspath,testRuntimeClasspath
org.xmlresolver:xmlresolver:5.3.3=spotbugs
org.yaml:snakeyaml:2.4=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
empty=spotbugsPlugins
13 changes: 6 additions & 7 deletions mdx-gateways/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ com.fasterxml.woodstox:woodstox-core:7.2.1=annotationProcessor,compileClasspath,
com.github.oowekyala.ooxml:nice-xml-messages:3.1=pmd
com.github.rholder:guava-retrying:2.0.0=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.spotbugs:spotbugs-annotations:4.10.2=annotationProcessor,testAnnotationProcessor
com.github.spotbugs:spotbugs-annotations:4.10.3=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.3=spotbugs
com.github.spotbugs:spotbugs-annotations:4.10.4=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.4=spotbugs
com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs
com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,checkstyle,compileClasspath,runtimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
com.google.code.gson:gson:2.13.2=pmd
Expand Down Expand Up @@ -110,7 +110,6 @@ org.junit.platform:junit-platform-engine:1.14.1=testCompileClasspath,testRuntime
org.junit.platform:junit-platform-launcher:1.14.1=testRuntimeClasspath
org.junit:junit-bom:5.14.1=testCompileClasspath,testRuntimeClasspath
org.junit:junit-bom:6.1.0=annotationProcessor,testAnnotationProcessor
org.junit:junit-bom:6.1.2=spotbugs
org.mockito:mockito-core:5.23.0=testCompileClasspath,testRuntimeClasspath
org.objenesis:objenesis:3.3=annotationProcessor,runtimeClasspath,testRuntimeClasspath
org.opentest4j:opentest4j:1.3.0=testCompileClasspath,testRuntimeClasspath
Expand Down Expand Up @@ -138,8 +137,8 @@ org.spockframework:spock-bom:2.4-groovy-4.0=testCompileClasspath,testRuntimeClas
org.spockframework:spock-core:2.4-groovy-4.0=testCompileClasspath,testRuntimeClasspath
org.xmlresolver:xmlresolver:5.3.3=checkstyle,pmd,spotbugs
org.yaml:snakeyaml:2.4=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.1=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.1=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.1=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.1=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.2=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.2=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.2=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.2=annotationProcessor,compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
empty=spotbugsPlugins
13 changes: 6 additions & 7 deletions mdx-models/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ com.fasterxml.woodstox:woodstox-core:7.2.1=compileClasspath,runtimeClasspath,tes
com.github.oowekyala.ooxml:nice-xml-messages:3.1=pmd
com.github.rholder:guava-retrying:2.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.spotbugs:spotbugs-annotations:4.10.2=annotationProcessor,testAnnotationProcessor
com.github.spotbugs:spotbugs-annotations:4.10.3=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.3=spotbugs
com.github.spotbugs:spotbugs-annotations:4.10.4=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.4=spotbugs
com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs
com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,checkstyle,compileClasspath,runtimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
com.google.code.gson:gson:2.13.2=pmd
Expand Down Expand Up @@ -107,7 +107,6 @@ org.junit.platform:junit-platform-engine:1.14.1=testCompileClasspath,testRuntime
org.junit.platform:junit-platform-launcher:1.14.1=testRuntimeClasspath
org.junit:junit-bom:5.14.1=testCompileClasspath,testRuntimeClasspath
org.junit:junit-bom:6.1.0=annotationProcessor,testAnnotationProcessor
org.junit:junit-bom:6.1.2=spotbugs
org.mockito:mockito-core:5.23.0=testCompileClasspath,testRuntimeClasspath
org.objenesis:objenesis:3.3=runtimeClasspath,testRuntimeClasspath
org.opentest4j:opentest4j:1.3.0=testCompileClasspath,testRuntimeClasspath
Expand All @@ -133,8 +132,8 @@ org.spockframework:spock-bom:2.4-groovy-4.0=testCompileClasspath,testRuntimeClas
org.spockframework:spock-core:2.4-groovy-4.0=testCompileClasspath,testRuntimeClasspath
org.xmlresolver:xmlresolver:5.3.3=checkstyle,pmd,spotbugs
org.yaml:snakeyaml:2.4=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
empty=spotbugsPlugins
3 changes: 2 additions & 1 deletion ...c/main/java/com/mx/path/model/mdx/accessor/managed_card/ManagedCardAlertBaseAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,13 @@ public AccessorResponse<MdxList<Alert>> list(String cardId) {
* Update a managed card alert
*
* @param cardId
* @param alertId
* @param alert
* @return
*/
@GatewayAPI
@API(description = "Update a managed card alert")
public AccessorResponse<Alert> update(String cardId, Alert alert) {
public AccessorResponse<Alert> update(String cardId, String alertId, Alert alert) {
throw new AccessorMethodNotImplementedException();
}

Expand Down
2 changes: 1 addition & 1 deletion ...roovy/com/mx/path/model/mdx/accessor/managed_card/ManagedCardAlertBaseAccessorTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ManagedCardAlertBaseAccessorTest extends Specification {
}

def "update throws"() {
when: subject.update("cardId", null)
when: subject.update("cardId", "alertId", null)
then: thrown(AccessorMethodNotImplementedException)
}

Expand Down
5 changes: 2 additions & 3 deletions mdx-web/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ com.fasterxml.woodstox:woodstox-core:7.1.1=compileClasspath,runtimeClasspath,tes
com.github.oowekyala.ooxml:nice-xml-messages:3.1=pmd
com.github.rholder:guava-retrying:2.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.spotbugs:spotbugs-annotations:4.10.2=annotationProcessor,compileClasspath,testAnnotationProcessor,testCompileClasspath
com.github.spotbugs:spotbugs-annotations:4.10.3=spotbugs
com.github.spotbugs:spotbugs:4.10.3=spotbugs
com.github.spotbugs:spotbugs-annotations:4.10.4=spotbugs
com.github.spotbugs:spotbugs:4.10.4=spotbugs
com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs
com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,checkstyle,compileClasspath,runtimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
com.google.code.gson:gson:2.13.2=compileClasspath,pmd,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
Expand Down Expand Up @@ -128,7 +128,6 @@ org.junit.platform:junit-platform-engine:6.0.3=testCompileClasspath,testRuntimeC
org.junit.platform:junit-platform-launcher:6.0.3=testRuntimeClasspath
org.junit:junit-bom:6.0.3=testCompileClasspath,testRuntimeClasspath
org.junit:junit-bom:6.1.0=annotationProcessor,testAnnotationProcessor
org.junit:junit-bom:6.1.2=spotbugs
org.mockito:mockito-core:5.23.0=testCompileClasspath,testRuntimeClasspath
org.mockito:mockito-junit-jupiter:5.23.0=testCompileClasspath,testRuntimeClasspath
org.objenesis:objenesis:3.3=runtimeClasspath,testRuntimeClasspath
Expand Down
4 changes: 2 additions & 2 deletions mdx-web/src/main/java/com/mx/path/model/mdx/web/controller/ManagedCardAlertsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public final ResponseEntity<MdxList<Alert>> getAlertList(@PathVariable("cardId")
}

@RequestMapping(value = "/users/{userId}/managed_cards/{cardId}/alerts/{id}", method = RequestMethod.PUT, consumes = BaseController.MDX_MEDIA)
public final ResponseEntity<Alert> updateAlert(@PathVariable("cardId") String cardId, @RequestBody Alert alert) {
AccessorResponse<Alert> response = gateway().managedCards().alerts().update(cardId, alert);
public final ResponseEntity<Alert> updateAlert(@PathVariable("cardId") String cardId, @PathVariable("id") String alertId, @RequestBody Alert alert) {
AccessorResponse<Alert> response = gateway().managedCards().alerts().update(cardId, alertId, alert);
return new ResponseEntity<>(response.getResult().wrapped(), createMultiMapForResponse(response.getHeaders()), HttpStatus.OK);
}

Expand Down
7 changes: 4 additions & 3 deletions ...c/test/groovy/com/mx/path/model/mdx/web/controller/ManagedCardAlertsControllerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,16 @@ class ManagedCardAlertsControllerTest extends Specification {

def "updateAlert interacts with gateway"() {
given:
def alertId = "alert-id"
def cardId = "card-id"
def alert = new Alert()

when:
doReturn(new AccessorResponse<Alert>().withResult(alert)).when(alertGateway).update(cardId, alert)
def response = subject.updateAlert(cardId, alert)
doReturn(new AccessorResponse<Alert>().withResult(alert)).when(alertGateway).update(cardId, alertId, alert)
def response = subject.updateAlert(cardId, alertId, alert)

then:
verify(alertGateway).update(cardId, alert) || true
verify(alertGateway).update(cardId, alertId, alert) || true
response.body == alert
}

Expand Down
13 changes: 6 additions & 7 deletions realtime/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ com.fasterxml.woodstox:woodstox-core:7.2.1=compileClasspath,runtimeClasspath,tes
com.github.oowekyala.ooxml:nice-xml-messages:3.1=pmd
com.github.rholder:guava-retrying:2.0.0=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
com.github.spotbugs:spotbugs-annotations:4.10.2=annotationProcessor,testAnnotationProcessor
com.github.spotbugs:spotbugs-annotations:4.10.3=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.3=spotbugs
com.github.spotbugs:spotbugs-annotations:4.10.4=compileClasspath,spotbugs,testCompileClasspath
com.github.spotbugs:spotbugs:4.10.4=spotbugs
com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs
com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,checkstyle,compileClasspath,runtimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath
com.google.code.gson:gson:2.13.2=pmd
Expand Down Expand Up @@ -108,7 +108,6 @@ org.junit.platform:junit-platform-engine:1.14.1=testCompileClasspath,testRuntime
org.junit.platform:junit-platform-launcher:1.14.1=testRuntimeClasspath
org.junit:junit-bom:5.14.1=testCompileClasspath,testRuntimeClasspath
org.junit:junit-bom:6.1.0=annotationProcessor,testAnnotationProcessor
org.junit:junit-bom:6.1.2=spotbugs
org.mockito:mockito-core:5.23.0=testCompileClasspath,testRuntimeClasspath
org.objenesis:objenesis:3.3=runtimeClasspath,testRuntimeClasspath
org.opentest4j:opentest4j:1.3.0=testCompileClasspath,testRuntimeClasspath
Expand All @@ -134,8 +133,8 @@ org.spockframework:spock-bom:2.4-groovy-4.0=testCompileClasspath,testRuntimeClas
org.spockframework:spock-core:2.4-groovy-4.0=testCompileClasspath,testRuntimeClasspath
org.xmlresolver:xmlresolver:5.3.3=checkstyle,pmd,spotbugs
org.yaml:snakeyaml:2.4=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.1=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-core:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.core:jackson-databind:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson.dataformat:jackson-dataformat-xml:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
tools.jackson:jackson-bom:3.2.2=compileClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
empty=spotbugsPlugins
Loading