Repository navigation
Conversation
edaa5e2 to
81baa2a
Compare
|
@coderabbitai review |
|
When the Recognize app announces its contact linking capability, the avatar menu of a contact offers to pick a picture from the faces Recognize found. The picker shows the faces of the person linked to the contact, or lets the user pick the person first, which links them in Recognize. The picked face goes through the usual cropper before it is saved. Closes nextcloud#5245 Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
The avatar menu lists the recognized people linked to the contact, one "Unlink from …" entry each, next to the entry that picks a face. Links can therefore be undone where they are made in this app, instead of only on the person page of the Photos app. Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
81baa2a to
823d0a2
Compare
|
Rebased to fix CI, No code change submitted |
✨ Finishing Touches: 💡 1
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR is part of a three-PR implementation of #5245 and nextcloud/recognize#1285. It also largely addresses nextcloud/recognize#498 (contact photos do not seed clustering in this PR) and nextcloud/recognize#1412 (recognize gets no relation editor, but personally I'm not sure whether that is really the place for it anyway. Perhaps recognize could read out relations from contacts?).
Other PRs
🤖 AI (if applicable)
I created this code with Claude Fable 5.1. I am a developer, but not in PHP or Vue. I reviewed the code and played with the new features in a local instance, and I think everything looks good.