Repository navigation
Conversation
Face clusters can be linked to a contact of one of the user's address books, by hand or by a scheduled job that compares the photos of the contacts with the clusters of the user. A cluster is only linked automatically when its photo matches exactly one cluster and no other contact matches that cluster; links made or removed by the user are never changed automatically. Unnamed clusters take the name of the contact they are linked to. An OCS API lets the Photos and Contacts apps search contacts, link and unlink people, list and crop the faces of a person, and use a face as the photo of the linked contact. The link is also exposed as a WebDAV property of the faces collection, and a capability announces the integration. Contact photos are analyzed with the built-in face classifier, so automatic linking is only available in that mode; the TaskProcessing backend only accepts files of the user. Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
The admin switch for automatic linking was not read from the initial state, so it always showed as off. Address book URIs are now also accepted the way the Contacts app spells them in DAV hrefs, and the link to a contact uses that spelling. Structured names are assembled in the usual order when a contact has no formatted name, a contact that cannot be JSON encoded no longer breaks the listing of people, and setting a contact photo rejects a half-specified contact instead of falling back to the linked one. Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
Assisted-by: Claude Code:claude-fable-5-1 Signed-off-by: Luc Timmerman <luc.timmerman@afas.nl>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR is part of a three-PR implementation of nextcloud/contacts#5245 and #1285. It also largely addresses #498 (contact photos do not seed clustering in this PR) and #1412 (recognize gets no relation editor, but personally I'm not sure whether that is really the place for it anyway. Perhaps recognize could read out relations from contacts?).
Other PRs
🤖 AI (if applicable)
I created this code with Claude Fable 5.1. I am a developer, but not in PHP or Vue. I reviewed the code and played with the new features in a local instance, and I think everything looks good.