Repository navigation
fix(personal-kits): fail closed on @agentkit overlays while the shared list is unset - #128
Merged
Merged
Conversation
…d list is unset Kit releases are named without the ak- prefix, so the prefix rule alone protected no @agentkit kit release while SKILLX_SHARED_SKILL_ALIASES was unset. Until that list holds at least one valid identity, every in-place overlay of an @agentkit/* identity is now refused with 422 overlay.shared_alias, and the detail names the missing operator step. Entries that are not identities no longer count as a configured list. Forks are unaffected. Closes #125 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RCDbVS52poV8kxgnXrrBY
…releases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016RCDbVS52poV8kxgnXrrBY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125 (option 2, the issue's recommendation). Related: #123 / #126.
Change
sharedSkills(apps/web/app/lib/personal-kits/kit-verify.ts): whileSKILLX_SHARED_SKILL_ALIASESholds no valid identity, every@agentkit/*identity is shared. An in-place overlay is then refused with422 overlay.shared_alias, and the detail names the missing operator step. Forks are unaffected.plan,none, mixed case) are dropped, so a wrong value cannot silently turn the fail-closed default off.ak-prefix) refused the entry.docs/personal-kits-api.md(guard semantics, which writes it runs on) anddocs/deployment-guide.md(Personal kits API paragraph).Verification
kit-verify.ts) and pass with it.npx vitest run: 124 files, 2421 passed, 3 skipped.pnpm typecheck: clean across all packages.ak-skills, fork test) are addressed in this PR.Note for #126
The deployment-guide paragraph #126 adds says that while the variable is unset a public kit "may overlay any other
@agentkit/<name>skill in place". After this PR, that statement is false: such overlays are refused until the list is set. That sentence should be updated when #126 lands.Generated by Claude Code