Skip to content

Add slot column to sleds tab on inventory page - #3416

Merged
charliepark merged 6 commits into
mainfrom
sleds-tab-sled-slot
Nov 20, 2026
Merged

charliepark merged 6 commits into
mainfrom
sleds-tab-sled-slot

Conversation

@charliepark

@charliepark charliepark commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

In oxidecomputer/omicron#11077 we provide the user with the sled's most recently-known physical location. This PR gets that onto the console's inventory page, and also on the data table on the sled's view page.

Post-feedback in the comments below, these are updated screenshots, [though the sort order is now by slot ID, unlike in the screenshots]:
Screenshot 2026-11-12 at 10 18 06 AM

Screenshot 2026-11-12 at 10 21 05 AM

Closes #3327

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
console Ready Ready Preview Nov 20, 2026 7:19pm UTC

Request Review

@david-crespo

Copy link
Copy Markdown
Collaborator

I would drop refresh. The only other pages that have it all have polling because they have a concept of transitional states: instances, support bundles, update.

@david-crespo

david-crespo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

How about putting the slot first since it's usually the thing people index on? It looks a little lopsided, I almost want to center or right align it but I don't think we do that. @benjaminleonard ?

image

@benjaminleonard

Copy link
Copy Markdown
Contributor

I prefer slot first. Leading 0 and tabular nums would do a similar thing for alignment, but last time I tried to enable tabular nums it didn't work. I'm convinced a new version of the font does have it, going to investigate.

@charliepark

Copy link
Copy Markdown
Contributor Author

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@fakemonster fakemonster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would find it pleasing for these to be sorted by slot as well (since we know we always get the full collection of sleds), but that's not a blocker

@david-crespo

Copy link
Copy Markdown
Collaborator

Yeah, I don’t see a downside to sorting by slot, otherwise it feels random. I’m guessing the API sort is by ID? Eventually we will have slots from multiple racks and we’ll have to group them by rack I guess.

@charliepark

Copy link
Copy Markdown
Contributor Author

Yeah, as I mentioned to Joe in chat yesterday, get amped for sort_by_datacenter_id_building_id_floor_id_room_id_row_number_slot_id

We'll have to revisit a number of interface assumptions when we get to multirack. In the near term, more sorting options in general in the API could be good (like, for users/groups, sort_by_name_and_id_ascending).

But agree that for now, sorting by slot is an easy affordance for reasonable people. Will get that in this morning and merge.

This branch was successfully deployed

1 active deployment
Preview — f9974139 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sled slot number to Inventory > Sleds table/sled view

4 participants