Repository navigation
Add slot column to sleds tab on inventory page - #3416
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I would drop refresh. The only other pages that have it all have polling because they have a concept of transitional states: instances, support bundles, update. |
|
How about putting the slot first since it's usually the thing people index on? It looks a little lopsided, I almost want to center or right align it but I don't think we do that. @benjaminleonard ?
|
|
I prefer slot first. Leading 0 and tabular nums would do a similar thing for alignment, but last time I tried to enable tabular nums it didn't work. I'm convinced a new version of the font does have it, going to investigate. |
|
@claude review |
fakemonster
left a comment
There was a problem hiding this comment.
i would find it pleasing for these to be sorted by slot as well (since we know we always get the full collection of sleds), but that's not a blocker
|
Yeah, I don’t see a downside to sorting by slot, otherwise it feels random. I’m guessing the API sort is by ID? Eventually we will have slots from multiple racks and we’ll have to group them by rack I guess. |
|
Yeah, as I mentioned to Joe in chat yesterday, get amped for We'll have to revisit a number of interface assumptions when we get to multirack. In the near term, more sorting options in general in the API could be good (like, for users/groups, But agree that for now, sorting by slot is an easy affordance for reasonable people. Will get that in this morning and merge. |
oxidecomputer/console@fe921de...55bc9f3 * [55bc9f3f](oxidecomputer/console@55bc9f3f) oxidecomputer/console#3427 * [37403197](oxidecomputer/console@37403197) oxidecomputer/console#3361 * [5f7377ba](oxidecomputer/console@5f7377ba) oxidecomputer/console#3416 * [0f508ce5](oxidecomputer/console@0f508ce5) oxidecomputer/console#3449

In oxidecomputer/omicron#11077 we provide the user with the sled's most recently-known physical location. This PR gets that onto the console's inventory page, and also on the data table on the sled's view page.
Post-feedback in the comments below, these are updated screenshots, [though the sort order is now by slot ID, unlike in the screenshots]:

Closes #3327